vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Merge pull request #24223 from shariquerik/disabled-button-on-upload

Browse source 
fix: added validation if upload is clicked without uploading file
This commit is contained in:
Shariq Ansari 2024-01-09 15:58:08 +05:30 • committed by GitHub
commit 004359ad6e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
frappe/public/js/frappe/file_uploader/FileUploader.vue
View file

@ -473,7 +473,7 @@ function check_restrictions(file) {
return is_correct_type && valid_file_size;
}
function upload_files() {
function upload_files(dialog) {
if (show_file_browser.value) {
return upload_via_file_browser();
}
@ -483,6 +483,14 @@ function upload_files() {
if (props.as_dataurl) {
return return_as_dataurl();
}
if (!files.value.length) {
frappe.msgprint(__("Please select a file first."));
return Promise.reject();
}
dialog?.get_primary_btn().prop("disabled", true);
dialog?.get_secondary_btn().prop("disabled", true);
return frappe.run_serially(files.value.map((file, i) => () => upload_file(file, i)));
}
function upload_via_file_browser() {

4
frappe/public/js/frappe/file_uploader/file_uploader.bundle.js
View file

@ -113,9 +113,7 @@ class FileUploader {
}
upload_files() {
this.dialog && this.dialog.get_primary_btn().prop("disabled", true);
this.dialog && this.dialog.get_secondary_btn().prop("disabled", true);
return this.uploader.upload_files();
return this.uploader.upload_files(this.dialog);
}
make_dialog(title) {