vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

refactor: frappe.utils.response.download_private_file

Browse source
This commit is contained in:
Gavin D'souza 2022-04-18 12:39:30 +05:30
parent 025ab70c25
commit 013c2543bd
1 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
frappe/utils/response.py
View file

@ -6,6 +6,7 @@ import decimal
import json
import mimetypes
import os
from typing import TYPE_CHECKING
from urllib.parse import quote
import werkzeug.utils
@ -22,6 +23,9 @@ from frappe import _
from frappe.core.doctype.access_log.access_log import make_access_log
from frappe.utils import cint, format_timedelta
if TYPE_CHECKING:
from frappe.core.doctype.file.file import File
def report_error(status_code):
"""Build error. Show traceback in developer mode"""
@ -209,28 +213,27 @@ def download_backup(path):
return send_private_file(path)
def download_private_file(path):
def download_private_file(path: str) -> Response:
"""Checks permissions and sends back private file"""
files = frappe.db.get_all("File", {"file_url": path})
can_access = False
files = frappe.get_all("File", filters={"file_url": path}, pluck="name")
# this file might be attached to multiple documents
# if the file is accessible from any one of those documents
# then it should be downloadable
for f in files:
_file = frappe.get_doc("File", f)
can_access = _file.is_downloadable()
if can_access:
make_access_log(doctype="File", document=_file.name, file_type=os.path.splitext(path)[-1][1:])
for fname in files:
file: "File" = frappe.get_doc("File", fname)
if can_access := file.is_downloadable():
break
if not can_access:
raise Forbidden(_("You don't have permission to access this file"))
make_access_log(doctype="File", document=file.name, file_type=os.path.splitext(path)[-1][1:])
return send_private_file(path.split("/private", 1)[1])
def send_private_file(path):
def send_private_file(path: str) -> Response:
path = os.path.join(frappe.local.conf.get("private_path", "private"), path.strip("/"))
filename = os.path.basename(path)