vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

perf: remove order_by from linked_with checks (#19229)

Browse source
This commit is contained in:
Ankush Menat 2022-12-12 15:39:46 +05:30 • committed by GitHub
parent a90fc27c75
commit 025906840d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 28 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
frappe/desk/form/linked_with.py
View file

@ -136,7 +136,9 @@ class SubmittableDocumentTree:
def get_submittable_doctypes(self) -> list[str]:
"""Returns list of submittable doctypes."""
if not self._submittable_doctypes:
self._submittable_doctypes = frappe.get_all("DocType", {"is_submittable": 1}, pluck="name")
self._submittable_doctypes = frappe.get_all(
"DocType", {"is_submittable": 1}, pluck="name", order_by=None
)
return self._submittable_doctypes
@ -155,6 +157,7 @@ def get_child_tables_of_doctypes(doctypes: list[str] = None):
fields=["parent", "fieldname", "options as child_table"],
filters=filters_for_docfield,
as_list=1,
order_by=None,
)
links += frappe.get_all(
@ -162,6 +165,7 @@ def get_child_tables_of_doctypes(doctypes: list[str] = None):
fields=["dt as parent", "fieldname", "options as child_table"],
filters=filters_for_customfield,
as_list=1,
order_by=None,
)
child_tables_by_doctype = defaultdict(list)
@ -275,6 +279,7 @@ def get_references_across_doctypes_by_dynamic_link_field(
fields=["parent as doctype", "fieldname", "options as doctype_fieldname"],
filters=filters_for_docfield,
as_list=1,
order_by=None,
)
links += frappe.get_all(
@ -282,6 +287,7 @@ def get_references_across_doctypes_by_dynamic_link_field(
fields=["dt as doctype", "fieldname", "options as doctype_fieldname"],
filters=filters_for_customfield,
as_list=1,
order_by=None,
)
links_by_doctype = defaultdict(list)
@ -328,17 +334,21 @@ def get_referencing_documents(
if not link_info.get("is_child"):
filters.extend(parent_filters or [])
return {from_table: frappe.get_all(from_table, filters, pluck="name")}
return {from_table: frappe.get_all(from_table, filters, pluck="name", order_by=None)}
filters.extend(child_filters or [])
res = frappe.get_all(from_table, filters=filters, fields=["name", "parenttype", "parent"])
res = frappe.get_all(
from_table, filters=filters, fields=["name", "parenttype", "parent"], order_by=None
)
documents = defaultdict(list)
for parent, rows in itertools.groupby(res, key=lambda row: row["parenttype"]):
if allowed_parents and parent not in allowed_parents:
continue
filters = (parent_filters or []) + [["name", "in", tuple(row.parent for row in rows)]]
documents[parent].extend(frappe.get_all(parent, filters=filters, pluck="name") or [])
documents[parent].extend(
frappe.get_all(parent, filters=filters, pluck="name", order_by=None) or []
)
return documents
@ -447,7 +457,7 @@ def get_linked_docs(doctype: str, name: str, linkinfo: dict | None = None) -> di
try:
if link.get("filters"):
ret = frappe.get_all(doctype=dt, fields=fields, filters=link.get("filters"))
ret = frappe.get_all(doctype=dt, fields=fields, filters=link.get("filters"), order_by=None)
elif link.get("get_parent"):
ret = None
@ -456,9 +466,11 @@ def get_linked_docs(doctype: str, name: str, linkinfo: dict | None = None) -> di
if not frappe.get_meta(doctype).istable:
continue
me = frappe.db.get_value(doctype, name, ["parenttype", "parent"], as_dict=True)
me = frappe.db.get_value(doctype, name, ["parenttype", "parent"], as_dict=True, order_by=None)
if me and me.parenttype == dt:
ret = frappe.get_all(doctype=dt, fields=fields, filters=[[dt, "name", "=", me.parent]])
ret = frappe.get_all(
doctype=dt, fields=fields, filters=[[dt, "name", "=", me.parent]], order_by=None
)
elif link.get("child_doctype"):
or_filters = [
@ -471,7 +483,12 @@ def get_linked_docs(doctype: str, name: str, linkinfo: dict | None = None) -> di
filters.append([link.get("child_doctype"), link.get("doctype_fieldname"), "=", doctype])
ret = frappe.get_all(
doctype=dt, fields=fields, filters=filters, or_filters=or_filters, distinct=True
doctype=dt,
fields=fields,
filters=filters,
or_filters=or_filters,
distinct=True,
order_by=None,
)
else:
@ -483,7 +500,9 @@ def get_linked_docs(doctype: str, name: str, linkinfo: dict | None = None) -> di
# dynamic link
if link.get("doctype_fieldname"):
filters.append([dt, link.get("doctype_fieldname"), "=", doctype])
ret = frappe.get_all(doctype=dt, fields=fields, filters=filters, or_filters=or_filters)
ret = frappe.get_all(
doctype=dt, fields=fields, filters=filters, or_filters=or_filters, order_by=None
)
else:
ret = None