vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: ensure Page.add_dropdown_item returns link even if it already exists (#13420)

Browse source
This commit is contained in:
Sagar Vora 2021-06-06 13:47:17 +05:30 • committed by GitHub
parent ce26ad2aef
commit 02765c98c9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
frappe/public/js/frappe/ui/page.js
View file

@ -409,6 +409,9 @@ frappe.ui.Page = class Page {
parent.parent().removeClass("hide");
}
let $link = this.is_in_group_button_dropdown(parent, 'li > a.grey-link', label);
if ($link) return $link;
let $li;
let $icon = ``;
@ -440,9 +443,8 @@ frappe.ui.Page = class Page {
</li>
`);
}
var $link = $li.find("a").on("click", click);
if (this.is_in_group_button_dropdown(parent, 'li > a.grey-link', label)) return;
$link = $li.find("a").on("click", click);
if (standard) {
$li.appendTo(parent);
@ -508,7 +510,7 @@ frappe.ui.Page = class Page {
let item = $(this).html();
return $(item).attr('data-label') === label;
});
return result.length > 0;
return result.length > 0 && result;
}
clear_btn_group(parent) {