From b66d3fe37ca5e3acf37b970be991c5e799b48b37 Mon Sep 17 00:00:00 2001 From: Rohit Waghchaure Date: Thu, 30 Aug 2018 16:32:09 +0530 Subject: [PATCH 1/2] On assignment notification is not send to the assigned user --- frappe/desk/form/assign_to.py | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/frappe/desk/form/assign_to.py b/frappe/desk/form/assign_to.py index f13f853636..621de8f260 100644 --- a/frappe/desk/form/assign_to.py +++ b/frappe/desk/form/assign_to.py @@ -163,4 +163,30 @@ def notify_assignment(assigned_by, owner, doc_type, doc_name, action='CLOSE', 'notify': notify } - arg["parenttype"] = "Assignment" \ No newline at end of file + if arg and arg.get("notify"): + _notify(arg) + +def _notify(args): + from frappe.utils import get_fullname, get_url + + args = frappe._dict(args) + contact = args.contact + txt = args.txt + + try: + if not isinstance(contact, list): + contact = [frappe.db.get_value("User", contact, "email") or contact] + + frappe.sendmail(\ + recipients=contact, + sender= frappe.db.get_value("User", frappe.session.user, "email"), + subject=_("New Message from {0}").format(get_fullname(frappe.session.user)), + template="new_message", + args={ + "from": get_fullname(frappe.session.user), + "message": txt, + "link": get_url() + }, + header=[_('New Message'), 'orange']) + except frappe.OutgoingEmailError: + pass \ No newline at end of file From b3f52156ef7f5d85e15270ac3d386d344eff2f54 Mon Sep 17 00:00:00 2001 From: Faris Ansari Date: Wed, 5 Sep 2018 12:52:26 +0530 Subject: [PATCH 2/2] fix: message --- frappe/desk/form/assign_to.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe/desk/form/assign_to.py b/frappe/desk/form/assign_to.py index 621de8f260..15ad442f92 100644 --- a/frappe/desk/form/assign_to.py +++ b/frappe/desk/form/assign_to.py @@ -180,7 +180,7 @@ def _notify(args): frappe.sendmail(\ recipients=contact, sender= frappe.db.get_value("User", frappe.session.user, "email"), - subject=_("New Message from {0}").format(get_fullname(frappe.session.user)), + subject=_("New message from {0}").format(get_fullname(frappe.session.user)), template="new_message", args={ "from": get_fullname(frappe.session.user), @@ -189,4 +189,4 @@ def _notify(args): }, header=[_('New Message'), 'orange']) except frappe.OutgoingEmailError: - pass \ No newline at end of file + pass