vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(ux): show email account name in error title if available (#35088)

Browse source
This commit is contained in:
Hussain Nagaria 2025-12-05 18:43:50 +05:30 • committed by GitHub
parent da92e7cd36
commit 046b4fa307
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
frappe/email/smtp.py
View file

@ -95,7 +95,7 @@ class SMTPServer:
return self._session
except smtplib.SMTPAuthenticationError:
self.throw_invalid_credentials_exception()
self.throw_invalid_credentials_exception(email_account=self.email_account)
except OSError as e:
# Invalid mail server -- due to refusing connection
@ -128,10 +128,17 @@ class SMTPServer:
self._session.quit()
@classmethod
def throw_invalid_credentials_exception(cls):
def throw_invalid_credentials_exception(cls, email_account=None):
original_exception = get_traceback() or "\n"
error_message = (
_("Please check your email login credentials.") + " " + original_exception.splitlines()[-1]
)
error_title = _("Invalid Credentials")
if email_account:
error_title = _("Invalid Credentials for Email Account: {0}").format(email_account)
frappe.throw(
_("Please check your email login credentials.") + " " + original_exception.splitlines()[-1],
title=_("Invalid Credentials"),
error_message,
title=error_title,
exc=InvalidEmailCredentials,
)