From 0482530ffd3813b9cfb2b7ecb40d1c5b2ed181ca Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Fri, 3 Feb 2023 20:04:11 +0530
Subject: [PATCH] fix: do not allow restricted fieldnames for custom fields

---
 .../custom/doctype/custom_field/custom_field.py   | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/frappe/custom/doctype/custom_field/custom_field.py b/frappe/custom/doctype/custom_field/custom_field.py
index 758d9c1e64..8953153be6 100644
--- a/frappe/custom/doctype/custom_field/custom_field.py
+++ b/frappe/custom/doctype/custom_field/custom_field.py
@@ -18,6 +18,18 @@ class CustomField(Document):
 		self.name = self.dt + "-" + self.fieldname
 
 	def set_fieldname(self):
+		restricted = (
+			"name",
+			"parent",
+			"creation",
+			"modified",
+			"modified_by",
+			"parentfield",
+			"parenttype",
+			"file_list",
+			"flags",
+			"docstatus",
+		)
 		if not self.fieldname:
 			label = self.label
 			if not label:
@@ -34,6 +46,9 @@ class CustomField(Document):
 		# fieldnames should be lowercase
 		self.fieldname = self.fieldname.lower()
 
+		if self.fieldname in restricted:
+			self.fieldname = self.fieldname + "1"
+
 	def before_insert(self):
 		self.set_fieldname()