From 04a40d286deea8e5641d0cc3a959fc90a5fcf809 Mon Sep 17 00:00:00 2001
From: Suraj Shetty <surajshetty3416@gmail.com>
Date: Fri, 5 Apr 2019 21:14:21 +0530
Subject: [PATCH] fix: Show alert message

- Append indicator element instead of adding
class to parent div to avoid css bleed
---
 frappe/public/js/frappe/ui/messages.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/frappe/public/js/frappe/ui/messages.js b/frappe/public/js/frappe/ui/messages.js
index 9293d497b5..9b8ff15b09 100644
--- a/frappe/public/js/frappe/ui/messages.js
+++ b/frappe/public/js/frappe/ui/messages.js
@@ -283,12 +283,12 @@ frappe.show_alert = function(message, seconds=7, actions={}) {
 			<a class="close">&times;</a>
 		</div>`);
 
-	div.find('.alert-message').append(message.message);
-
 	if(message.indicator) {
-		div.find('.alert-message').addClass('indicator '+ message.indicator);
+		div.find('.alert-message').append(`<span class="indicator ${message.indicator}"></span>`);
 	}
 
+	div.find('.alert-message').append(message.message);
+
 	if (body_html) {
 		div.find('.alert-body').show().html(body_html);
 	}