From 04d1c9dc04f217fea7fc04d57eacf768b32963da Mon Sep 17 00:00:00 2001 From: Saqib Ansari Date: Thu, 6 Nov 2025 15:23:45 +0530 Subject: [PATCH] fix: linting issues --- .../permission_inspector/permission_inspector.js | 2 +- .../permission_type/test_permission_type.py | 16 ++++++++-------- frappe/permissions.py | 6 ++++-- 3 files changed, 13 insertions(+), 11 deletions(-) diff --git a/frappe/core/doctype/permission_inspector/permission_inspector.js b/frappe/core/doctype/permission_inspector/permission_inspector.js index 0c6b85988e..743563f690 100644 --- a/frappe/core/doctype/permission_inspector/permission_inspector.js +++ b/frappe/core/doctype/permission_inspector/permission_inspector.js @@ -38,5 +38,5 @@ frappe.ui.form.on("Permission Inspector", { "options", `${standard_options}\n${custom_options}` ); - } + }, }); diff --git a/frappe/core/doctype/permission_type/test_permission_type.py b/frappe/core/doctype/permission_type/test_permission_type.py index 04cadffac6..ba33859454 100644 --- a/frappe/core/doctype/permission_type/test_permission_type.py +++ b/frappe/core/doctype/permission_type/test_permission_type.py @@ -33,11 +33,15 @@ class IntegrationTestPermissionType(IntegrationTestCase): self._verify_user_lacks_permission(doc_type, ptype_name, user.name) - update_permission_property(doctype=doc_type, role=user_role, permlevel=0, ptype=ptype_name, value=1) + update_permission_property( + doctype=doc_type, role=user_role, permlevel=0, ptype=ptype_name, value=1 + ) self._verify_user_has_permission(doc_type, ptype_name, user.name) - update_permission_property(doctype=doc_type, role=user_role, permlevel=0, ptype=ptype_name, value=0) + update_permission_property( + doctype=doc_type, role=user_role, permlevel=0, ptype=ptype_name, value=0 + ) finally: frappe.delete_doc("User", user.name, force=True) @@ -92,12 +96,8 @@ class IntegrationTestPermissionType(IntegrationTestCase): def _verify_user_lacks_permission(self, doc_type, ptype_name, user_name): """Verify that user does not have the specified permission type.""" - self.assertFalse( - frappe.has_permission(doc_type, ptype=ptype_name, user=user_name) - ) + self.assertFalse(frappe.has_permission(doc_type, ptype=ptype_name, user=user_name)) def _verify_user_has_permission(self, doc_type, ptype_name, user_name): """Verify that user has the specified permission type.""" - self.assertTrue( - frappe.has_permission(doc_type, ptype=ptype_name, user=user_name) - ) + self.assertTrue(frappe.has_permission(doc_type, ptype=ptype_name, user=user_name)) diff --git a/frappe/permissions.py b/frappe/permissions.py index 1eefdb8700..eb88809667 100644 --- a/frappe/permissions.py +++ b/frappe/permissions.py @@ -742,13 +742,15 @@ def get_doc_name(doc): return None return doc if isinstance(doc, str) else str(doc.name) -def get_rights(doctype = None): + +def get_rights(doctype=None): if not doctype: return std_rights custom_rights = get_doctype_ptype_map().get(doctype, []) return list(std_rights) + custom_rights -def allow_everything(doctype = None): + +def allow_everything(doctype=None): """Return a dict with access to everything, eg. {"read": 1, "write": 1, ...}.""" return {ptype: 1 for ptype in get_rights(doctype)}