From 04e10c4c9e7e8d36d57e80b584265c9cf23388b7 Mon Sep 17 00:00:00 2001
From: Faris Ansari <netchamp.faris@gmail.com>
Date: Fri, 22 Oct 2021 19:14:59 +0530
Subject: [PATCH] fix: Barcode rendering

- CSS variables in svg don't work in PDF
- styling is done via external css now to make it work in form as well as PDF
---
 frappe/public/js/frappe/form/controls/barcode.js | 3 ---
 frappe/public/scss/common/controls.scss          | 7 +++++++
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/frappe/public/js/frappe/form/controls/barcode.js b/frappe/public/js/frappe/form/controls/barcode.js
index 04bdb3f19e..3a678b6a97 100644
--- a/frappe/public/js/frappe/form/controls/barcode.js
+++ b/frappe/public/js/frappe/form/controls/barcode.js
@@ -56,9 +56,6 @@ frappe.ui.form.ControlBarcode = class ControlBarcode extends frappe.ui.form.Cont
 	get_options(value) {
 		// get JsBarcode options
 		let options = {};
-		options.background = "var(--control-bg)";
-		options.lineColor = "var(--text-color)";
-		options.font = "var(--font-stack)";
 		options.fontSize = "16";
 		options.width = "3";
 		options.height = "50";
diff --git a/frappe/public/scss/common/controls.scss b/frappe/public/scss/common/controls.scss
index a10cd454a6..954916c911 100644
--- a/frappe/public/scss/common/controls.scss
+++ b/frappe/public/scss/common/controls.scss
@@ -231,6 +231,13 @@ textarea.form-control {
 	background-color: var(--control-bg);
 	border-radius: var(--border-radius);
 	padding: var(--padding-md);
+
+	svg > rect {
+		fill: var(--control-bg) !important;
+	}
+	svg > g {
+		fill: var(--text-color) !important;
+	}
 }
 
 @media (min-width: 768px) {