From 05fca5b16b163bc641df2ad336ad7928a7ea7117 Mon Sep 17 00:00:00 2001 From: Akhil Narang Date: Tue, 18 Mar 2025 15:53:42 +0530 Subject: [PATCH] chore: skip a few tests for sqlite Signed-off-by: Akhil Narang --- frappe/commands/test_commands.py | 36 +++++++++++++++++++++ frappe/core/doctype/doctype/test_doctype.py | 5 +++ 2 files changed, 41 insertions(+) diff --git a/frappe/commands/test_commands.py b/frappe/commands/test_commands.py index 6d6365a5e3..de9f154cd4 100644 --- a/frappe/commands/test_commands.py +++ b/frappe/commands/test_commands.py @@ -304,6 +304,10 @@ class TestCommands(BaseTestCommands): self.execute("bench --site {test_site} restore {database}", site_data) self.assertEqual(self.returncode, 1) + @skipIf( + frappe.conf.db_type == "sqlite", + "Not for SQLite for now", + ) def test_partial_restore(self): _now = now() for num in range(10): @@ -330,6 +334,10 @@ class TestCommands(BaseTestCommands): self.assertEqual(self.returncode, 0) self.assertEqual(frappe.db.count("ToDo"), todo_count) + @skipIf( + frappe.conf.db_type == "sqlite", + "Not for SQLite for now", + ) def test_recorder(self): frappe.recorder.stop() @@ -528,6 +536,10 @@ class TestCommands(BaseTestCommands): self.assertEqual(conf[key], value) + @skipIf( + frappe.conf.db_type == "sqlite", + "Not for SQLite for now", + ) def test_different_db_username(self): site = frappe.generate_hash() user = "".join(secrets.choice(string.ascii_letters) for _ in range(8)) @@ -565,6 +577,10 @@ class TestCommands(BaseTestCommands): ) self.assertEqual(self.returncode, 0) + @skipIf( + frappe.conf.db_type == "sqlite", + "Not for SQLite for now", + ) def test_existing_db_username(self): site = frappe.generate_hash() user = "".join(secrets.choice(string.ascii_letters) for _ in range(8)) @@ -687,6 +703,10 @@ class TestBackups(BaseTestCommands): ) self.assertEqual(self.returncode, 0) + @skipIf( + frappe.conf.db_type == "sqlite", + "Not for SQLite for now", + ) def test_backup_fails_with_exit_code(self): """Provide incorrect options to check if exit code is 1""" odb = BackupGenerator( @@ -778,6 +798,10 @@ class TestBackups(BaseTestCommands): self.execute("bench --site {site} backup --verbose") self.assertEqual(self.returncode, 0) + @skipIf( + frappe.conf.db_type == "sqlite", + "Not for SQLite for now", + ) def test_backup_only_specific_doctypes(self): """Take a backup with (include) backup options set in the site config `frappe.conf.backup.includes`""" self.execute( @@ -789,6 +813,10 @@ class TestBackups(BaseTestCommands): database = fetch_latest_backups(partial=True)["database"] self.assertEqual([], missing_in_backup(self.backup_map["includes"]["includes"], database)) + @skipIf( + frappe.conf.db_type == "sqlite", + "Not for SQLite for now", + ) def test_backup_excluding_specific_doctypes(self): """Take a backup with (exclude) backup options set (`frappe.conf.backup.excludes`, `--exclude`)""" # test 1: take a backup with frappe.conf.backup.excludes @@ -811,6 +839,10 @@ class TestBackups(BaseTestCommands): database = fetch_latest_backups(partial=True)["database"] self.assertFalse(exists_in_backup(self.backup_map["excludes"]["excludes"], database)) + @skipIf( + frappe.conf.db_type == "sqlite", + "Not for SQLite for now", + ) def test_selective_backup_priority_resolution(self): """Take a backup with conflicting backup options set (`frappe.conf.excludes`, `--include`)""" self.execute( @@ -821,6 +853,10 @@ class TestBackups(BaseTestCommands): database = fetch_latest_backups(partial=True)["database"] self.assertEqual([], missing_in_backup(self.backup_map["includes"]["includes"], database)) + @skipIf( + frappe.conf.db_type == "sqlite", + "Not for SQLite for now", + ) def test_dont_backup_conf(self): """Take a backup ignoring frappe.conf.backup settings (with --ignore-backup-conf option)""" self.execute("bench --site {site} backup --ignore-backup-conf") diff --git a/frappe/core/doctype/doctype/test_doctype.py b/frappe/core/doctype/doctype/test_doctype.py index 60bf788064..6b20d7872c 100644 --- a/frappe/core/doctype/doctype/test_doctype.py +++ b/frappe/core/doctype/doctype/test_doctype.py @@ -4,6 +4,7 @@ import os import random import string import unittest +from unittest.case import skipIf from unittest.mock import patch import frappe @@ -56,6 +57,10 @@ class TestDocType(IntegrationTestCase): doc = new_doctype(name).insert() doc.delete() + @skipIf( + frappe.conf.db_type == "sqlite", + "Not for SQLite for now", + ) def test_making_sequence_on_change(self): frappe.delete_doc_if_exists("DocType", self._testMethodName) dt = new_doctype(self._testMethodName).insert(ignore_permissions=True)