From ca2e04d35d4e7de367830672c861fb75c5ed2b19 Mon Sep 17 00:00:00 2001
From: barredterra <14891507+barredterra@users.noreply.github.com>
Date: Sun, 8 Oct 2023 16:00:44 +0200
Subject: [PATCH 1/3] feat(listview): move likes to the right

---
 frappe/public/js/frappe/list/list_view.js | 27 ++++++++++++++---------
 frappe/public/scss/desk/list.scss         | 11 +++------
 2 files changed, 20 insertions(+), 18 deletions(-)

diff --git a/frappe/public/js/frappe/list/list_view.js b/frappe/public/js/frappe/list/list_view.js
index 57b8f88f2d..50309f2707 100644
--- a/frappe/public/js/frappe/list/list_view.js
+++ b/frappe/public/js/frappe/list/list_view.js
@@ -631,9 +631,6 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
 		let subject_html = `
 			<input class="level-item list-check-all" type="checkbox"
 				title="${__("Select All")}">
-			<span class="level-item list-liked-by-me hidden-xs">
-				<span title="${__("Likes")}">${frappe.utils.icon("es-solid-heart", "sm", "like-icon")}</span>
-			</span>
 			<span class="level-item" data-sort-by="${subject_field.fieldname}"
 				title="${__("Click to sort by {0}", [subject_field.label])}">
 				${__(subject_field.label)}
@@ -667,7 +664,16 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
 			})
 			.join("");
 
-		return this.get_header_html_skeleton($columns, '<span class="list-count"></span>');
+		const right_html = `
+			<span class="list-count"></span>
+			<span class="level-item list-liked-by-me hidden-xs">
+				<span title="${__("Liked by me")}">
+					${frappe.utils.icon("es-solid-heart", "sm", "like-icon")}
+				</span>
+			</span>
+		`;
+
+		return this.get_header_html_skeleton($columns, right_html);
 	}
 
 	get_header_html_skeleton(left = "", right = "") {
@@ -909,19 +915,23 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
 
 		let comment_count = null;
 		if (this.list_view_settings && !this.list_view_settings.disable_comment_count) {
-			comment_count = $(`<span class="comment-count"></span>`);
+			comment_count = $(`<span class="comment-count d-flex align-items-center"></span>`);
 			$(comment_count).append(`
 				${frappe.utils.icon("es-line-chat-alt")}
 				${doc._comment_count > 99 ? "99+" : doc._comment_count || 0}`);
 		}
 
 		html += `
-			<div class="level-item list-row-activity hidden-xs">
+			<div class="level-item list-row-activity hidden-xs d-flex align-items-center">
 				<div class="hidden-md hidden-xs">
 					${settings_button || assigned_to}
 				</div>
-				${modified}
+				<span class="modified">${modified}</span>
 				${comment_count ? $(comment_count).prop("outerHTML") : ""}
+				${comment_count ? '<span class="mx-2">·</span>' : ""}
+				<span class="list-row-like hidden-xs style="margin-bottom: 1px;">
+					${this.get_like_html(doc)}
+				</span>
 			</div>
 			<div class="level-item visible-xs text-right">
 				${this.get_indicator_dot(doc)}
@@ -1012,9 +1022,6 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
 		div.innerHTML = `
 			<span class="level-item select-like">
 				<input class="list-row-checkbox" type="checkbox">
-				<span class="list-row-like hidden-xs style="margin-bottom: 1px;">
-					${this.get_like_html(doc)}
-				</span>
 			</span>
 			<span class="level-item ${seen} ellipsis">
 				<a class="ellipsis"></a>
diff --git a/frappe/public/scss/desk/list.scss b/frappe/public/scss/desk/list.scss
index 34bac0f73c..57510e24d1 100644
--- a/frappe/public/scss/desk/list.scss
+++ b/frappe/public/scss/desk/list.scss
@@ -118,10 +118,10 @@
 
 		&> span {
 			display: inline-block;
+		}
 
-			&:not(:last-child) {
-				margin-right: 15px;
-			}
+		.modified {
+			margin-right: var(--margin-sm);
 		}
 
 		.comment-count {
@@ -131,7 +131,6 @@
 		.frappe-timestamp {
 			font-size: var(--text-xs);
 			white-space: nowrap;
-			min-width: 30px;
 		}
 
 		.list-assignments, .list-actions {
@@ -195,10 +194,6 @@ $level-margin-right: 8px;
 		color: var(--text-color);
 	}
 
-	.level-item:not(.file-select) {
-		margin-right: $level-margin-right;
-	}
-
 	&.seen {
 		font-weight: normal;
 	}

From 681364815d2db6f903178403dfe2d499d7a0dc0e Mon Sep 17 00:00:00 2001
From: barredterra <14891507+barredterra@users.noreply.github.com>
Date: Sun, 8 Oct 2023 16:03:17 +0200
Subject: [PATCH 2/3] fix(listview): assigned to

- don't show "-" if assignments are empty
- vertically center avatars in row
- remove unused avatar-empty class
---
 frappe/public/js/frappe/list/list_view.js | 7 ++-----
 frappe/public/scss/desk/avatar.scss       | 5 -----
 2 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/frappe/public/js/frappe/list/list_view.js b/frappe/public/js/frappe/list/list_view.js
index 50309f2707..83e864abb9 100644
--- a/frappe/public/js/frappe/list/list_view.js
+++ b/frappe/public/js/frappe/list/list_view.js
@@ -901,14 +901,11 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
 
 		const modified = comment_when(doc.modified, true);
 
-		let assigned_to = `<div class="list-assignments">
-			<span class="avatar avatar-small">
-			<span class="avatar-empty"></span>
-		</div>`;
+		let assigned_to = ``;
 
 		let assigned_users = JSON.parse(doc._assign || "[]");
 		if (assigned_users.length) {
-			assigned_to = `<div class="list-assignments">
+			assigned_to = `<div class="list-assignments d-flex align-items-center">
 					${frappe.avatar_group(assigned_users, 3, { filterable: true })[0].outerHTML}
 				</div>`;
 		}
diff --git a/frappe/public/scss/desk/avatar.scss b/frappe/public/scss/desk/avatar.scss
index 40b86258b4..615cb6604e 100644
--- a/frappe/public/scss/desk/avatar.scss
+++ b/frappe/public/scss/desk/avatar.scss
@@ -95,11 +95,6 @@
 	.standard-image {
 		font-size: var(--text-xs);
 	}
-
-	.avatar-empty::after {
-		content: "\002D";
-		line-height: 28px;
-	}
 }
 
 .avatar-medium {

From ff0e3c73ad4979651469e71196f5413d0fc108bf Mon Sep 17 00:00:00 2001
From: barredterra <14891507+barredterra@users.noreply.github.com>
Date: Sun, 8 Oct 2023 16:16:39 +0200
Subject: [PATCH 3/3] refactor: redundant CSS/classes

---
 frappe/public/js/frappe/list/list_view.js | 2 +-
 frappe/public/scss/desk/list.scss         | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/frappe/public/js/frappe/list/list_view.js b/frappe/public/js/frappe/list/list_view.js
index 83e864abb9..be3bc59a3b 100644
--- a/frappe/public/js/frappe/list/list_view.js
+++ b/frappe/public/js/frappe/list/list_view.js
@@ -919,7 +919,7 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
 		}
 
 		html += `
-			<div class="level-item list-row-activity hidden-xs d-flex align-items-center">
+			<div class="level-item list-row-activity hidden-xs">
 				<div class="hidden-md hidden-xs">
 					${settings_button || assigned_to}
 				</div>
diff --git a/frappe/public/scss/desk/list.scss b/frappe/public/scss/desk/list.scss
index 57510e24d1..804e12fcef 100644
--- a/frappe/public/scss/desk/list.scss
+++ b/frappe/public/scss/desk/list.scss
@@ -94,6 +94,7 @@
 	.level-right {
 		flex: 1;
 		overflow: visible;
+		align-items: center;
 	}
 
 	.tag-col {