From 085d57bbd277a06f843e12e36e12f6bef776424a Mon Sep 17 00:00:00 2001 From: Prssanna Desai Date: Thu, 4 Jul 2019 12:54:34 +0530 Subject: [PATCH] fix: codacy fixes --- .../js/frappe/list/list_sidebar_group_by.js | 26 +++++++++---------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/frappe/public/js/frappe/list/list_sidebar_group_by.js b/frappe/public/js/frappe/list/list_sidebar_group_by.js index 9e42b382ad..aaab5a1422 100644 --- a/frappe/public/js/frappe/list/list_sidebar_group_by.js +++ b/frappe/public/js/frappe/list/list_sidebar_group_by.js @@ -2,23 +2,23 @@ frappe.provide('frappe.views'); frappe.views.ListGroupBy = class ListGroupBy { - constructor(opts) { + constructor(opts) { $.extend(this, opts); this.make_wrapper(); - this.user_settings = frappe.get_user_settings(this.doctype); - this.group_by_fields = ['assigned_to']; - if(this.user_settings.group_by_fields) { + this.user_settings = frappe.get_user_settings(this.doctype); + this.group_by_fields = ['assigned_to']; + if(this.user_settings.group_by_fields) { this.group_by_fields = this.group_by_fields.concat(this.user_settings.group_by_fields); } this.render_group_by_items(); this.make_group_by_fields_modal(); this.setup_dropdown(); this.setup_filter_by(); - } + } - make_group_by_fields_modal() { - let d = new frappe.ui.Dialog ({ + make_group_by_fields_modal() { + let d = new frappe.ui.Dialog ({ title: __("Add Filter By"), fields: this.get_group_by_dropdown_fields() }); @@ -71,7 +71,7 @@ frappe.views.ListGroupBy = class ListGroupBy { `; - } + }; let html = this.group_by_fields.map(get_item_html).join(''); this.$wrapper.find('.list-group-by-fields').html(html); } @@ -91,7 +91,7 @@ frappe.views.ListGroupBy = class ListGroupBy { }); } - get_group_by_dropdown_fields() { + get_group_by_dropdown_fields() { let group_by_fields = []; let fields = this.list_view.meta.fields.filter((f)=> ["Select", "Link"].includes(f.fieldtype)); group_by_fields.push({ @@ -115,7 +115,7 @@ frappe.views.ListGroupBy = class ListGroupBy { doctype: this.doctype, current_filters: this.list_view.get_filters_for_args(), field: field, - } + }; return frappe.call('frappe.desk.listview.get_group_by_count', args).then((data) => { if(field === 'assigned_to') { let current_user = data.message.find(user => user.name === frappe.session.user); @@ -139,7 +139,7 @@ frappe.views.ListGroupBy = class ListGroupBy { ${name} ${field.count} `; - } + }; let standard_html = `