vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

[minor] in create_custom_field, if you set "append" to insert_after, it till append to the last field

Browse source
This commit is contained in:
Rushabh Mehta 2017-06-20 18:29:42 +05:30
parent 2c2368de7b
commit 0879ecf326
1 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
frappe/custom/doctype/custom_field/custom_field.py
View file

@ -25,15 +25,15 @@ class CustomField(Document):
self.fieldname = self.fieldname.lower()
def validate(self):
meta = frappe.get_meta(self.dt)
meta = frappe.get_meta(self.dt, cached=False)
fieldnames = [df.fieldname for df in meta.get("fields")]
if self.insert_after=='append':
self.insert_after = fieldnames[-1]
if self.insert_after and self.insert_after in fieldnames:
self.idx = fieldnames.index(self.insert_after) + 1
if not self.idx:
self.idx = len(fieldnames) + 1
self._old_fieldtype = self.db_get('fieldtype')
if not self.fieldname:
@ -83,17 +83,18 @@ def create_custom_field_if_values_exist(doctype, df):
create_custom_field(doctype, df)
def create_custom_field(doctype, df):
df = frappe._dict(df)
if not df.fieldname and df.label:
df.fieldname = frappe.scrub(df.label)
if not frappe.db.get_value("Custom Field", {"dt": doctype, "fieldname": df.fieldname}):
frappe.get_doc({
"doctype":"Custom Field",
"dt": doctype,
"permlevel": df.permlevel or 0,
"label": df.label,
"fieldname": df.fieldname or df.label.lower().replace(' ', '_'),
"fieldtype": df.fieldtype,
"fieldname": df.fieldname,
"fieldtype": df.fieldtype or 'Data',
"options": df.options,
"insert_after": df.insert_after,
"print_hide": df.print_hide,