From 08c5d095afccdacd3ef72daafbdcf5268e3ad1de Mon Sep 17 00:00:00 2001 From: Rahul Agrawal <12agrawalrahul@gmail.com> Date: Sat, 10 Jan 2026 11:13:42 +0530 Subject: [PATCH] fix: use select instead of check --- .../doctype/print_settings/print_settings.json | 14 ++++++++------ .../doctype/print_settings/print_settings.py | 2 +- frappe/printing/page/print/print.js | 4 +--- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/frappe/printing/doctype/print_settings/print_settings.json b/frappe/printing/doctype/print_settings/print_settings.json index 8c259f1944..7e617e3603 100644 --- a/frappe/printing/doctype/print_settings/print_settings.json +++ b/frappe/printing/doctype/print_settings/print_settings.json @@ -8,7 +8,7 @@ "pdf_settings", "send_print_as_pdf", "repeat_header_footer", - "use_chrome_for_standard_format", + "pdf_generator_for_standard_format", "column_break_4", "pdf_page_size", "pdf_page_height", @@ -173,17 +173,18 @@ "label": "PDF Page Width (in mm)" }, { - "default": "0", - "fieldname": "use_chrome_for_standard_format", - "fieldtype": "Check", - "label": "Use Chrome for Standard Format" + "default": "wkhtmltopdf", + "fieldname": "pdf_generator_for_standard_format", + "fieldtype": "Select", + "label": "PDF Generator for Standard Format", + "options": "wkhtmltopdf\nchrome" } ], "icon": "fa fa-cog", "index_web_pages_for_search": 1, "issingle": 1, "links": [], - "modified": "2026-01-10 08:47:37.915137", + "modified": "2026-01-10 11:08:14.847391", "modified_by": "Administrator", "module": "Printing", "name": "Print Settings", @@ -198,6 +199,7 @@ } ], "quick_entry": 1, + "row_format": "Dynamic", "sort_field": "creation", "sort_order": "DESC", "states": [], diff --git a/frappe/printing/doctype/print_settings/print_settings.py b/frappe/printing/doctype/print_settings/print_settings.py index d0c6e593af..8342c9b535 100644 --- a/frappe/printing/doctype/print_settings/print_settings.py +++ b/frappe/printing/doctype/print_settings/print_settings.py @@ -24,6 +24,7 @@ class PrintSettings(Document): enable_raw_printing: DF.Check font: DF.Literal["Default", "Helvetica Neue", "Arial", "Helvetica", "Inter", "Verdana", "Monospace"] font_size: DF.Float + pdf_generator_for_standard_format: DF.Literal["wkhtmltopdf", "chrome"] pdf_page_height: DF.Float pdf_page_size: DF.Literal[ "A0", @@ -62,7 +63,6 @@ class PrintSettings(Document): print_style: DF.Link | None repeat_header_footer: DF.Check send_print_as_pdf: DF.Check - use_chrome_for_standard_format: DF.Check with_letterhead: DF.Check # end: auto-generated types diff --git a/frappe/printing/page/print/print.js b/frappe/printing/page/print/print.js index 7ca545a867..c6c3978fa4 100644 --- a/frappe/printing/page/print/print.js +++ b/frappe/printing/page/print/print.js @@ -712,9 +712,7 @@ frappe.ui.form.PrintView = class { } get_pdf_generator(pdf_generator) { if (!pdf_generator) { - pdf_generator = cint(this.print_settings.use_chrome_for_standard_format) - ? "chrome" - : "wkhtmltopdf"; + pdf_generator = this.print_settings.pdf_generator_for_standard_format || "wkhtmltopdf"; } return pdf_generator; }