From 92218e443b0e6b63b866e8e94ee0e7ae30628dcd Mon Sep 17 00:00:00 2001 From: Akhil Narang Date: Thu, 5 Oct 2023 17:12:20 +0530 Subject: [PATCH 1/2] chore(exporter): fix typo in method name Signed-off-by: Akhil Narang --- frappe/types/exporter.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe/types/exporter.py b/frappe/types/exporter.py index edab26fe33..f90bbb5365 100644 --- a/frappe/types/exporter.py +++ b/frappe/types/exporter.py @@ -62,7 +62,7 @@ class TypeExporter: self.controller_path = Path(inspect.getfile(get_controller(self.doctype))) def export_types(self): - self._guess_indetation() + self._guess_indentation() new_code = self._generate_code() self._replace_or_add_code(new_code) @@ -192,7 +192,7 @@ class TypeExporter: frappe.msgprint(frappe._("Failed to export python type hints"), alert=True) return False - def _guess_indetation( + def _guess_indentation( self, ) -> str: from token import INDENT From 85c3be814dba93f49d90706b8a939d7fe6cbb0b4 Mon Sep 17 00:00:00 2001 From: Akhil Narang Date: Thu, 5 Oct 2023 17:15:26 +0530 Subject: [PATCH 2/2] fix(exporter): some methods had the wrong return types Signed-off-by: Akhil Narang --- frappe/types/exporter.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe/types/exporter.py b/frappe/types/exporter.py index f90bbb5365..97551e0c01 100644 --- a/frappe/types/exporter.py +++ b/frappe/types/exporter.py @@ -137,7 +137,7 @@ class TypeExporter: return f"from {filepath} import {class_name}", class_name - def _map_fieldtype(self, field) -> type | None: + def _map_fieldtype(self, field) -> str | None: fieldtype = field.fieldtype.replace(" ", "") field_definition = "" @@ -194,7 +194,7 @@ class TypeExporter: def _guess_indentation( self, - ) -> str: + ) -> None: from token import INDENT with self.controller_path.open() as f: