vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Merge pull request #17816 from resilient-tech/fix-df-mutation

Browse source 
fix: dont mutate `df` when creating custom fields
This commit is contained in:
mergify[bot] 2022-08-13 11:06:03 +00:00 • committed by GitHub
commit 096cd9a46e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
frappe/custom/doctype/custom_field/custom_field.py
View file

@ -186,10 +186,13 @@ def create_custom_fields(custom_fields, ignore_validate=False, update=True):
field = frappe.db.get_value("Custom Field", {"dt": doctype, "fieldname": df["fieldname"]})
if not field:
try:
df = df.copy()
df["owner"] = "Administrator"
create_custom_field(doctype, df, ignore_validate=ignore_validate)
except frappe.exceptions.DuplicateEntryError:
pass
elif update:
custom_field = frappe.get_doc("Custom Field", field)
custom_field.flags.ignore_validate = ignore_validate