Merge pull request #36668 from sokumon/sidebar-generation

fix: dont consider private sidebar while module sidebar generation
This commit is contained in:
Soham Kulkarni 2026-02-04 01:18:20 +05:30 committed by GitHub
commit 09de01be70
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -51,7 +51,8 @@ class WorkspaceSidebar(Document):
def before_save(self):
self.export_sidebar()
self.set_module()
if not self.for_user:
self.set_module()
def export_sidebar(self):
allow_export = (
@ -274,8 +275,8 @@ def auto_generate_sidebar_from_module():
sidebars = []
for module in frappe.get_all("Module Def", pluck="name"):
if not (
frappe.db.exists("Workspace Sidebar", {"module": module})
or frappe.db.exists("Workspace Sidebar", {"name": module})
frappe.db.exists("Workspace Sidebar", {"module": module, "for_user": None})
or frappe.db.exists("Workspace Sidebar", {"name": module, "for_user": None})
):
module_info = get_module_info(module)
sidebar_items = create_sidebar_items(module_info)