From 60b2d92af8d005dfa54d606bdc7c67b1376ba411 Mon Sep 17 00:00:00 2001 From: Akhil Narang Date: Wed, 3 Sep 2025 17:56:41 +0530 Subject: [PATCH] fix(data_import): set payload count from existing importer Don't create a new one, especially one that doesn't have all parameters (main issue here: console=False) Signed-off-by: Akhil Narang --- frappe/core/doctype/data_import/data_import.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/frappe/core/doctype/data_import/data_import.py b/frappe/core/doctype/data_import/data_import.py index 40cfc5bca5..e49d1b93db 100644 --- a/frappe/core/doctype/data_import/data_import.py +++ b/frappe/core/doctype/data_import/data_import.py @@ -77,10 +77,11 @@ class DataImport(Document): return validate_google_sheets_url(self.google_sheets_url) - def set_payload_count(self): + def set_payload_count(self, importer: Importer | None = None): if self.import_file: - i = self.get_importer() - payloads = i.import_file.get_payloads_for_import() + if importer is None: + importer = self.get_importer() + payloads = importer.import_file.get_payloads_for_import() self.payload_count = len(payloads) @frappe.whitelist() @@ -268,9 +269,9 @@ def import_file(doctype, file_path, import_type, submit_after_import=False, cons data_import.import_type = ( "Insert New Records" if import_type.lower() == "insert" else "Update Existing Records" ) - data_import.set_payload_count() i = Importer(doctype=doctype, file_path=file_path, data_import=data_import, console=console) + data_import.set_payload_count(i) i.import_data()