vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

chore: validate arg for rename_field()

Browse source
This commit is contained in:
anandbaburajan 2023-11-17 00:31:04 +05:30
parent 0ff08e4e0f
commit 0aab6160a4
1 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
frappe/model/utils/rename_field.py
View file

@ -8,19 +8,21 @@ from frappe.model.utils.user_settings import sync_user_settings, update_user_set
from frappe.utils.password import rename_password_field
def rename_field(doctype, old_fieldname, new_fieldname):
def rename_field(doctype, old_fieldname, new_fieldname, validate=True):
"""This functions assumes that doctype is already synced"""
meta = frappe.get_meta(doctype, cached=False)
new_field = meta.get_field(new_fieldname)
if not new_field:
print("rename_field: " + (new_fieldname) + " not found in " + doctype)
return
if not meta.issingle and not frappe.db.has_column(doctype, old_fieldname):
print("rename_field: " + (old_fieldname) + " not found in table for: " + doctype)
# never had the field?
return
if validate:
if not new_field:
print("rename_field: " + (new_fieldname) + " not found in " + doctype)
return
if not meta.issingle and not frappe.db.has_column(doctype, old_fieldname):
print("rename_field: " + (old_fieldname) + " not found in table for: " + doctype)
# never had the field?
return
if new_field.fieldtype in table_fields:
# change parentfield of table mentioned in options