vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Merge pull request #38316 from AarDG10/feat-qb-gc

Browse source 
feat(custom): add separator support for Group_concat in Mariadb
This commit is contained in:
Aarol D'Souza 2026-03-30 20:11:47 +05:30 • committed by GitHub
commit 0afbf2a98e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 28 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
frappe/query_builder/custom.py
View file

@ -15,6 +15,28 @@ class GROUP_CONCAT(DistinctOptionFunction):
alias (Optional[str], optional): [ is this an alias? ]. Defaults to None.
"""
super().__init__("GROUP_CONCAT", column, alias=alias)
self._separator = ","
@builder
def separator(self, separator: str = ""):
"""Adds a separator to the GROUP_CONCAT function.
Args:
separator (str, optional): [separator to be used]. Defaults to ",".
"""
self._separator = separator
def get_sql(self, **kwargs):
query_alias = self.alias
self.alias = None
sql = super().get_sql(**kwargs)
if self._separator:
sql = f"{sql[:-1]} SEPARATOR {frappe.db.escape(self._separator)})"
self.alias = query_alias
if self.alias:
quote = kwargs.get("quote_char", "`")
sql += f" {quote}{self.alias}{quote}"
return sql
class STRING_AGG(DistinctOptionFunction):

7
frappe/tests/test_query_builder.py
View file

@ -35,7 +35,12 @@ def unimplemented_for(*dbtypes: db_type_is) -> Callable:
@run_only_if(db_type_is.MARIADB)
class TestCustomFunctionsMariaDB(IntegrationTestCase):
def test_concat(self):
self.assertEqual("GROUP_CONCAT('Notes')", GroupConcat("Notes").get_sql())
self.assertEqual("GROUP_CONCAT('Notes' SEPARATOR ',')", GroupConcat("Notes").get_sql())
user = frappe.qb.DocType("User")
query = frappe.qb.from_(user).select(GroupConcat(user.email).separator(" | ").as_("user_list"))
sql = query.get_sql()
self.assertIn("SEPARATOR ' | '", sql)
self.assertIn("`user_list`", sql)
def test_match(self):
query = Match("Notes")