From 73c7984fcdab5228d809121c04e76ddcfc3c9f12 Mon Sep 17 00:00:00 2001 From: Faris Ansari Date: Wed, 5 Sep 2018 14:06:43 +0530 Subject: [PATCH] fix: frappe.utils.get_url --- frappe/utils/data.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/frappe/utils/data.py b/frappe/utils/data.py index 1dd3270109..d1a5a51511 100644 --- a/frappe/utils/data.py +++ b/frappe/utils/data.py @@ -728,13 +728,17 @@ def get_url(uri=None, full_address=False): port = frappe.conf.http_port or frappe.conf.webserver_port - if host_name and ':' not in host_name and port: + if host_name and not url_contains_port(host_name) and port: host_name = host_name + ':' + str(port) url = urljoin(host_name, uri) if uri else host_name return url +def url_contains_port(url): + parts = url.split(':') + return len(parts) > 2 + def get_host_name(): return get_url().rsplit("//", 1)[-1]