diff --git a/frappe/permissions.py b/frappe/permissions.py
index c534cd15c3..32295182bf 100644
--- a/frappe/permissions.py
+++ b/frappe/permissions.py
@@ -145,9 +145,9 @@ def update_share_permissions(role_permissions, doc, user):
 
 	if permissions_by_share:
 		for ptype in share_ptypes:
-			if ptype:
+			if permissions_by_share[ptype]:
 				role_permissions[ptype] = 1
-
+		
 def get_role_permissions(meta, user=None, verbose=False):
 	"""Returns dict of evaluated role permissions like `{"read": True, "write":False}`
 
diff --git a/frappe/public/js/frappe/model/perm.js b/frappe/public/js/frappe/model/perm.js
index 8c9f7e3f90..47fb9703a4 100644
--- a/frappe/public/js/frappe/model/perm.js
+++ b/frappe/public/js/frappe/model/perm.js
@@ -76,7 +76,7 @@ $.extend(frappe.perm, {
 
 			// apply permissions from shared
 			if(docinfo.shared) {
-				for(var i=0; i<docinfo.shared; i++) {
+				for(var i=0; i<docinfo.shared.length; i++) {
 					var s = docinfo.shared[i];
 					if(s.user===user) {
 						perm[0]["read"] = perm[0]["read"] || s.read;