diff --git a/frappe/desk/doctype/number_card/number_card.js b/frappe/desk/doctype/number_card/number_card.js index ac881d47cf..ea60e2a194 100644 --- a/frappe/desk/doctype/number_card/number_card.js +++ b/frappe/desk/doctype/number_card/number_card.js @@ -4,8 +4,11 @@ frappe.ui.form.on("Number Card", { refresh: function (frm) { if (!frappe.boot.developer_mode && frm.doc.is_standard) { - frm.disable_form(); + frm.disable_save(); + } else { + frm.enable_save(); } + frm.set_df_property("filters_section", "hidden", 1); frm.set_df_property("dynamic_filters_section", "hidden", 1); frm.trigger("set_options"); @@ -19,12 +22,7 @@ frappe.ui.form.on("Number Card", { } if (frm.doc.type == "Custom") { - if (!frappe.boot.developer_mode) { - frm.disable_form(); - } frm.filters = eval(frm.doc.filters_config); - frm.trigger("set_filters_description"); - frm.trigger("set_method_description"); frm.trigger("render_filters_table"); } frm.trigger("set_parent_document_type"); @@ -68,49 +66,7 @@ frappe.ui.form.on("Number Card", { frm.set_df_property("dynamic_filters_section", "hidden", 1); }, - set_filters_description: function (frm) { - if (frm.doc.type == "Custom") { - frm.fields_dict.filters_config.set_description(` - Set the filters here. For example: -
-
-[{
- fieldname: "company",
- label: __("Company"),
- fieldtype: "Link",
- options: "Company",
- default: frappe.defaults.get_user_default("Company"),
- reqd: 1
-},
-{
- fieldname: "account",
- label: __("Account"),
- fieldtype: "Link",
- options: "Account",
- reqd: 1
-}]
-`);
- }
- },
-
- set_method_description: function (frm) {
- if (frm.doc.type == "Custom") {
- frm.fields_dict.method.set_description(`
- Set the path to a whitelisted function that will return the data for the number card in the format:
-
-
-{
- "value": value,
- "fieldtype": "Currency",
- "route_options": {"from_date": "2023-05-23"},
- "route": ["query-report", "Permitted Documents For User"]
-}
-`);
- }
- },
-
type: function (frm) {
- frm.trigger("set_filters_description");
if (frm.doc.type == "Report") {
frm.set_query("report_name", () => {
return {
diff --git a/frappe/desk/doctype/number_card/number_card.json b/frappe/desk/doctype/number_card/number_card.json
index 50447a7bdb..dbe5177bdb 100644
--- a/frappe/desk/doctype/number_card/number_card.json
+++ b/frappe/desk/doctype/number_card/number_card.json
@@ -117,6 +117,7 @@
"fieldname": "is_standard",
"fieldtype": "Check",
"label": "Is Standard",
+ "no_copy": 1,
"read_only_depends_on": "eval: !frappe.boot.developer_mode"
},
{
@@ -165,6 +166,7 @@
},
{
"depends_on": "eval: doc.type == 'Custom'",
+ "description": "Set the path to a whitelisted function that will return the data for the number card in the format:\n\n\n{\n\t\"value\": value,\n\t\"fieldtype\": \"Currency\",\n\t\"route_options\": {\"from_date\": \"2023-05-23\"},\n\t\"route\": [\"query-report\", \"Permitted Documents For User\"]\n}",
"fieldname": "method",
"fieldtype": "Data",
"label": "Method",
@@ -177,6 +179,7 @@
"label": "Custom Configuration"
},
{
+ "description": "Set the filters here. For example:\n\n[{\n\tfieldname: \"company\",\n\tlabel: __(\"Company\"),\n\tfieldtype: \"Link\",\n\toptions: \"Company\",\n\tdefault: frappe.defaults.get_user_default(\"Company\"),\n\treqd: 1\n},\n{\n\tfieldname: \"account\",\n\tlabel: __(\"Account\"),\n\tfieldtype: \"Link\",\n\toptions: \"Account\",\n\treqd: 1\n}]\n",
"fieldname": "filters_config",
"fieldtype": "Code",
"label": "Filters Configuration",
@@ -200,7 +203,7 @@
}
],
"links": [],
- "modified": "2023-08-28 22:23:56.286804",
+ "modified": "2023-11-09 13:44:00.280846",
"modified_by": "Administrator",
"module": "Desk",
"name": "Number Card",