diff --git a/frappe/public/build.json b/frappe/public/build.json index fe1d467a39..3a1e2a664f 100755 --- a/frappe/public/build.json +++ b/frappe/public/build.json @@ -90,7 +90,6 @@ "public/less/desk.less", "public/less/module.less", "public/less/flex.less", - "public/less/notifications.less", "public/less/link_preview.less", "public/less/form.less", "public/less/mobile.less", diff --git a/frappe/public/js/frappe/form/controls/color.js b/frappe/public/js/frappe/form/controls/color.js index f954002b33..8efde67e50 100644 --- a/frappe/public/js/frappe/form/controls/color.js +++ b/frappe/public/js/frappe/form/controls/color.js @@ -35,8 +35,8 @@ frappe.ui.form.ControlColor = frappe.ui.form.ControlData.extend({ set_formatted_input: function(value) { this._super(value); - if (!value) value = '#FFFFFF'; - const contrast = frappe.ui.color.get_contrast_color(value); + if (!value) value = '#F4F5F5'; + const contrast = frappe.ui.color.get_contrast_color(value); this.$input.css({ "background-color": value, "color": contrast diff --git a/frappe/public/js/frappe/ui/filters/edit_filter.html b/frappe/public/js/frappe/ui/filters/edit_filter.html index a09817a8c7..59185f3d4a 100644 --- a/frappe/public/js/frappe/ui/filters/edit_filter.html +++ b/frappe/public/js/frappe/ui/filters/edit_filter.html @@ -12,7 +12,7 @@
-
+
diff --git a/frappe/public/js/frappe/ui/filters/filter.js b/frappe/public/js/frappe/ui/filters/filter.js index 14c089fe39..209fa8485e 100644 --- a/frappe/public/js/frappe/ui/filters/filter.js +++ b/frappe/public/js/frappe/ui/filters/filter.js @@ -406,6 +406,8 @@ frappe.ui.filter_utils = { }, get_selected_value(field, condition) { + if (!field) return; + let val = field.get_value(); if (typeof val === 'string') { diff --git a/frappe/public/js/frappe/ui/filters/filter_list.js b/frappe/public/js/frappe/ui/filters/filter_list.js index 36d19398e3..571edd0ce9 100644 --- a/frappe/public/js/frappe/ui/filters/filter_list.js +++ b/frappe/public/js/frappe/ui/filters/filter_list.js @@ -64,7 +64,6 @@ frappe.ui.FilterGroup = class { if (!this.wrapper) { this.wrapper = $('.filter-popover'); - console.log('shownn', this.filters); if (hide_empty_filters) { this.toggle_empty_filters(false); this.add_filters_to_popover(this.filters); @@ -76,8 +75,8 @@ frappe.ui.FilterGroup = class { }); this.filter_button.on('hidden.bs.popover', (e) => { - this.on_change(); this.update_filters(); + this.on_change(); }); $(window).on('hashchange', () => { @@ -243,7 +242,9 @@ frappe.ui.FilterGroup = class { } update_filters() { - this.filters = this.filters.filter((f) => f.field); // remove hidden filters + // remove hidden filters and undefined filters + this.filters.map(f => !f.get_selected_value() && f.remove()); + this.filters = this.filters.filter(f => f.get_selected_value() && f.field); this.update_filter_button(); this.filters.length === 0 && this.toggle_empty_filters(true); diff --git a/frappe/public/js/frappe/widgets/chart_widget.js b/frappe/public/js/frappe/widgets/chart_widget.js index cb7b080ccf..31f0881391 100644 --- a/frappe/public/js/frappe/widgets/chart_widget.js +++ b/frappe/public/js/frappe/widgets/chart_widget.js @@ -473,7 +473,7 @@ export default class ChartWidget extends Widget { /* eslint-disable indent */ this.chart_actions = $(`