vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

perf: Remove socketio reconnect attempts

Browse source 
It works just fine without it. This sends duplicate events.
This commit is contained in:
Ankush Menat 2023-06-29 14:09:40 +05:30
parent d772365d5d
commit 0ea7f77dd1
1 changed files with 0 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
frappe/public/js/frappe/socketio_client.js
View file

@ -52,7 +52,6 @@ frappe.socketio = {
});
frappe.socketio.setup_listeners();
frappe.socketio.setup_reconnect();
$(document).on("form-load form-rename", function (e, frm) {
if (!frm.doc || frm.is_new()) {
@ -175,30 +174,6 @@ frappe.socketio = {
frappe.socketio.process_response(data, "progress");
});
},
setup_reconnect: function () {
// subscribe again to open_tasks
frappe.socketio.socket.on("connect", function () {
// wait for 5 seconds before subscribing again
// because it takes more time to start python server than nodejs server
// and we use validation requests to python server for subscribing
setTimeout(function () {
$.each(frappe.socketio.open_tasks, function (task_id, opts) {
frappe.socketio.subscribe(task_id, opts);
});
// re-connect open docs
$.each(frappe.socketio.open_docs, function (d) {
if (locals[d.doctype] && locals[d.doctype][d.name]) {
frappe.socketio.doc_subscribe(d.doctype, d.name);
}
});
if (cur_frm && cur_frm.doc && !cur_frm.is_new()) {
frappe.socketio.doc_open(cur_frm.doc.doctype, cur_frm.doc.name);
}
}, 5000);
});
},
process_response: function (data, method) {
if (!data) {
return;