From 0f1e1c48af935e22fa6d9e3deb57d34715857c8a Mon Sep 17 00:00:00 2001
From: KerollesFathy <kerollesfhabib@gmail.com>
Date: Sun, 11 Jan 2026 22:50:33 +0000
Subject: [PATCH] refactor: clear active filter on 'x' button click and remove
 redundant clear filter option

---
 frappe/public/js/frappe/list/list_filter.js | 22 +++++++--------------
 1 file changed, 7 insertions(+), 15 deletions(-)

diff --git a/frappe/public/js/frappe/list/list_filter.js b/frappe/public/js/frappe/list/list_filter.js
index ff6e40a99b..6649134589 100644
--- a/frappe/public/js/frappe/list/list_filter.js
+++ b/frappe/public/js/frappe/list/list_filter.js
@@ -20,6 +20,13 @@ export default class ListFilter {
 			[],
 			__("Saved Filters")
 		);
+
+		// Clear active filter on clicking 'x' button
+		const filter_x_btn = $(".filter-x-button");
+		filter_x_btn.on("click", () => {
+			this.active_filter = null;
+			this.update_active_filter_label("Saved Filters");
+		});
 	}
 
 	render_saved_filters() {
@@ -45,7 +52,6 @@ export default class ListFilter {
 		});
 
 		this.append_create_new_item($menu);
-		this.append_clear_selected_filter($menu);
 	}
 
 	apply_saved_filter(filter_name, filter_label) {
@@ -87,20 +93,6 @@ export default class ListFilter {
 		});
 		$menu.append($create_item);
 	}
-	append_clear_selected_filter($menu) {
-		const clear_filters = {
-			name: "clear_selected",
-			filter_name: "Clear Selected Filter",
-		};
-
-		const $clear_item = this.filter_template(clear_filters, true);
-		$clear_item.find(".filter-label").on("click", (e) => {
-			this.list_view.filter_area.clear();
-			this.active_filter = null;
-			this.update_active_filter_label("Saved Filters");
-		});
-		$menu.append($clear_item);
-	}
 
 	show_create_filter_dialog() {
 		const fields = [