From 536f9d9180745ebdf1c053348fa65aba0f9f3728 Mon Sep 17 00:00:00 2001 From: KerollesFathy Date: Sun, 29 Mar 2026 10:27:59 +0000 Subject: [PATCH 1/3] fix: add options description for Currency fieldtype --- frappe/public/js/form_builder/components/FieldProperties.vue | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/frappe/public/js/form_builder/components/FieldProperties.vue b/frappe/public/js/form_builder/components/FieldProperties.vue index 7311ed4bef..a43e94e500 100644 --- a/frappe/public/js/form_builder/components/FieldProperties.vue +++ b/frappe/public/js/form_builder/components/FieldProperties.vue @@ -63,6 +63,10 @@ let docfield_df = computed(() => { if (store.form.selected_field.fieldtype === "Select") { df.description = __("Enter list of Options, each on a new line."); + } else if (store.form.selected_field.fieldtype === "Currency") { + df.description = __( + "fieldname of the currency field or a cached value (e.g. Company:company:default_currency)." + ); } else { df.description = ""; } From 1941bb0a6907a65a3f67b8a8953c6280bf07ae00 Mon Sep 17 00:00:00 2001 From: KerollesFathy Date: Sun, 29 Mar 2026 10:45:35 +0000 Subject: [PATCH 2/3] refactor: use lookup map for options field descriptions instead of if else --- .../form_builder/components/FieldProperties.vue | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/frappe/public/js/form_builder/components/FieldProperties.vue b/frappe/public/js/form_builder/components/FieldProperties.vue index a43e94e500..f86f73fd54 100644 --- a/frappe/public/js/form_builder/components/FieldProperties.vue +++ b/frappe/public/js/form_builder/components/FieldProperties.vue @@ -61,15 +61,14 @@ let docfield_df = computed(() => { df.options = ["", "Email", "Name", "Phone", "URL", "Barcode", "IBAN"]; } - if (store.form.selected_field.fieldtype === "Select") { - df.description = __("Enter list of Options, each on a new line."); - } else if (store.form.selected_field.fieldtype === "Currency") { - df.description = __( + const df_desc = { + Select: __("Enter list of Options, each on a new line."), + Currency: __( "fieldname of the currency field or a cached value (e.g. Company:company:default_currency)." - ); - } else { - df.description = ""; - } + ), + }; + + df.description = df_desc[store.form.selected_field.fieldtype] || ""; } // show link_filters docfield only when link field is selected From 903538f6af54c851db2e22d019b809aad805987c Mon Sep 17 00:00:00 2001 From: KerollesFathy Date: Mon, 30 Mar 2026 17:57:12 +0000 Subject: [PATCH 3/3] refactor: enahnce variable names and description Co-authored-by: Ejaaz Khan --- .../public/js/form_builder/components/FieldProperties.vue | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/frappe/public/js/form_builder/components/FieldProperties.vue b/frappe/public/js/form_builder/components/FieldProperties.vue index f86f73fd54..b8f8eebee8 100644 --- a/frappe/public/js/form_builder/components/FieldProperties.vue +++ b/frappe/public/js/form_builder/components/FieldProperties.vue @@ -61,14 +61,14 @@ let docfield_df = computed(() => { df.options = ["", "Email", "Name", "Phone", "URL", "Barcode", "IBAN"]; } - const df_desc = { + const FIELD_DESCRIPTIONS = { Select: __("Enter list of Options, each on a new line."), Currency: __( - "fieldname of the currency field or a cached value (e.g. Company:company:default_currency)." + "Enter the fieldname of the currency field or a cached value (e.g. Company:company:default_currency)." ), }; - - df.description = df_desc[store.form.selected_field.fieldtype] || ""; + const fieldtype = store.form.selected_field?.fieldtype; + df.description = FIELD_DESCRIPTIONS[fieldtype] || ""; } // show link_filters docfield only when link field is selected