From 0fbac0927b7d99900cad9ec3ff1aa228c1acb3bd Mon Sep 17 00:00:00 2001 From: David Arnold Date: Sun, 8 Dec 2024 01:15:47 +0100 Subject: [PATCH] ci: fix type check for manual trigger (#28701) --- .github/workflows/_base-type-check.yml | 27 +++++++++++++++++--------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/.github/workflows/_base-type-check.yml b/.github/workflows/_base-type-check.yml index 3e446adfb6..e5970d1c06 100644 --- a/.github/workflows/_base-type-check.yml +++ b/.github/workflows/_base-type-check.yml @@ -19,11 +19,12 @@ jobs: with: github-token: ${{secrets.GITHUB_TOKEN}} script: | + const ref = context.payload.pull_request ? context.payload.pull_request.head.sha : github.context.sha; const { data: pyprojectContent } = await github.rest.repos.getContent({ owner: context.repo.owner, repo: context.repo.repo, path: 'pyproject.toml', - ref: context.payload.pull_request.head.sha + ref: ref }); const content = Buffer.from(pyprojectContent.content, 'base64').toString(); const toml = require('toml'); @@ -38,14 +39,22 @@ jobs: github-token: ${{secrets.GITHUB_TOKEN}} script: | const { mypyFiles } = ${{ steps.get-pyproject.outputs.result }}; - const { data: changedFiles } = await github.rest.pulls.listFiles({ - owner: context.repo.owner, - repo: context.repo.repo, - pull_number: context.payload.pull_request.number - }); - const changedMypyFiles = changedFiles - .filter(file => mypyFiles.includes(file.filename)) - .map(file => file.filename); + + let changedMypyFiles = []; + + if (context.payload.pull_request) { + const { data: changedFiles } = await github.rest.pulls.listFiles({ + owner: context.repo.owner, + repo: context.repo.repo, + pull_number: context.payload.pull_request.number + }); + changedMypyFiles = changedFiles + .filter(file => mypyFiles.includes(file.filename)) + .map(file => file.filename); + } else { + // If not a pull request, assume all mypy files are changed + changedMypyFiles = mypyFiles; + } return changedMypyFiles.length > 0; - name: Set up Python