vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

test: separate out risky tests (#25179)

Browse source
This commit is contained in:
Ankush Menat 2024-02-29 21:40:08 +05:30 • committed by GitHub
parent f7bff58935
commit 0fff2755d6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 38 additions and 35 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

59
frappe/tests/test_db.py
View file

@ -56,27 +56,6 @@ class TestDB(FrappeTestCase):
frappe.db.rollback(save_point=savepoint)
self.fail("Long running queries not timing out")
def test_skip_locking(self):
with self.primary_connection():
name = frappe.db.get_value("User", "Administrator", for_update=True, skip_locked=True)
self.assertEqual(name, "Administrator")
with self.secondary_connection():
name = frappe.db.get_value("User", "Administrator", for_update=True, skip_locked=True)
self.assertFalse(name)
@timeout(5, "Lock timeout should have been 0")
def test_no_wait(self):
with self.primary_connection():
name = frappe.db.get_value("User", "Administrator", for_update=True)
self.assertEqual(name, "Administrator")
with self.secondary_connection():
self.assertRaises(
frappe.QueryTimeoutError,
lambda: frappe.db.get_value("User", "Administrator", for_update=True, wait=False),
)
@patch.dict(frappe.conf, {"http_timeout": 20, "enable_db_statement_timeout": 1})
def test_db_timeout_computation(self):
set_request(method="GET", path="/")
@ -990,6 +969,44 @@ class TestReplicaConnections(FrappeTestCase):
self.assertEqual(write_connection, db_id())
class TestConcurrency(FrappeTestCase):
@timeout(5, "There shouldn't be any lock wait")
def test_skip_locking(self):
with self.primary_connection():
name = frappe.db.get_value("User", "Administrator", for_update=True, skip_locked=True)
self.assertEqual(name, "Administrator")
with self.secondary_connection():
name = frappe.db.get_value("User", "Administrator", for_update=True, skip_locked=True)
self.assertFalse(name)
@timeout(5, "Lock timeout should have been 0")
def test_no_wait(self):
with self.primary_connection():
name = frappe.db.get_value("User", "Administrator", for_update=True)
self.assertEqual(name, "Administrator")
with self.secondary_connection():
self.assertRaises(
frappe.QueryTimeoutError,
lambda: frappe.db.get_value("User", "Administrator", for_update=True, wait=False),
)
@timeout(5, "Deletion stuck on lock timeout")
def test_delete_race_condition(self):
note = frappe.new_doc("Note")
note.title = note.content = frappe.generate_hash()
note.insert()
frappe.db.commit() # ensure that second connection can see the document
with self.primary_connection():
n1 = frappe.get_doc(note.doctype, note.name)
n1.save()
with self.secondary_connection():
self.assertRaises(frappe.QueryTimeoutError, frappe.delete_doc, note.doctype, note.name)
class TestSqlIterator(FrappeTestCase):
def test_db_sql_iterator(self):
test_queries = [

14
frappe/tests/test_document.py
View file

@ -492,20 +492,6 @@ class TestDocument(FrappeTestCase):
changed_val = frappe.db.get_single_value(c.doctype, key)
self.assertEqual(val, changed_val)
@timeout(5, "Deletion stuck on lock timeout")
def test_delete_race_condition(self):
note = frappe.new_doc("Note")
note.title = note.content = frappe.generate_hash()
note.insert()
frappe.db.commit() # ensure that second connection can see the document
with self.primary_connection():
n1 = frappe.get_doc(note.doctype, note.name)
n1.save()
with self.secondary_connection():
self.assertRaises(frappe.QueryTimeoutError, frappe.delete_doc, note.doctype, note.name)
class TestDocumentWebView(FrappeTestCase):
def get(self, path, user="Guest"):