From 10edae65249582a4f8cb0e1d85fa17035297b075 Mon Sep 17 00:00:00 2001
From: Saqib Ansari <nextchamp.saqib@gmail.com>
Date: Mon, 24 Jan 2022 17:21:15 +0530
Subject: [PATCH] feat: new autocomplete control

---
 frappe/core/doctype/docfield/docfield.json            |  4 ++--
 frappe/database/mariadb/database.py                   |  3 ++-
 frappe/model/__init__.py                              |  3 ++-
 frappe/public/js/frappe/form/controls/autocomplete.js | 11 +++++++++++
 frappe/public/js/frappe/form/formatters.js            |  3 +++
 5 files changed, 20 insertions(+), 4 deletions(-)

diff --git a/frappe/core/doctype/docfield/docfield.json b/frappe/core/doctype/docfield/docfield.json
index 26ddce7d35..69c8c3505f 100644
--- a/frappe/core/doctype/docfield/docfield.json
+++ b/frappe/core/doctype/docfield/docfield.json
@@ -98,7 +98,7 @@
    "label": "Type",
    "oldfieldname": "fieldtype",
    "oldfieldtype": "Select",
-   "options": "Attach\nAttach Image\nBarcode\nButton\nCheck\nCode\nColor\nColumn Break\nCurrency\nData\nDate\nDatetime\nDuration\nDynamic Link\nFloat\nFold\nGeolocation\nHeading\nHTML\nHTML Editor\nIcon\nImage\nInt\nLink\nLong Text\nMarkdown Editor\nPassword\nPercent\nRead Only\nRating\nSection Break\nSelect\nSignature\nSmall Text\nTab Break\nTable\nTable MultiSelect\nText\nText Editor\nTime",
+   "options": "Autocomplete\nAttach\nAttach Image\nBarcode\nButton\nCheck\nCode\nColor\nColumn Break\nCurrency\nData\nDate\nDatetime\nDuration\nDynamic Link\nFloat\nFold\nGeolocation\nHeading\nHTML\nHTML Editor\nIcon\nImage\nInt\nLink\nLong Text\nMarkdown Editor\nPassword\nPercent\nRead Only\nRating\nSection Break\nSelect\nSignature\nSmall Text\nTab Break\nTable\nTable MultiSelect\nText\nText Editor\nTime",
    "reqd": 1,
    "search_index": 1
   },
@@ -540,7 +540,7 @@
  "index_web_pages_for_search": 1,
  "istable": 1,
  "links": [],
- "modified": "2022-01-03 11:56:19.812863",
+ "modified": "2022-01-04 11:56:19.812863",
  "modified_by": "Administrator",
  "module": "Core",
  "name": "DocField",
diff --git a/frappe/database/mariadb/database.py b/frappe/database/mariadb/database.py
index 6b827a4e89..325b97081b 100644
--- a/frappe/database/mariadb/database.py
+++ b/frappe/database/mariadb/database.py
@@ -52,7 +52,8 @@ class MariaDBDatabase(Database):
 			'Barcode':		('longtext', ''),
 			'Geolocation':	('longtext', ''),
 			'Duration':		('decimal', '21,9'),
-			'Icon':			('varchar', self.VARCHAR_LEN)
+			'Icon':			('varchar', self.VARCHAR_LEN),
+			'Autocomplete': ('varchar', self.VARCHAR_LEN),
 		}
 
 	def get_connection(self):
diff --git a/frappe/model/__init__.py b/frappe/model/__init__.py
index b50a0304a5..232ffbe771 100644
--- a/frappe/model/__init__.py
+++ b/frappe/model/__init__.py
@@ -35,7 +35,8 @@ data_fieldtypes = (
 	'Barcode',
 	'Geolocation',
 	'Duration',
-	'Icon'
+	'Icon',
+	'Autocomplete'
 )
 
 attachment_fieldtypes = (
diff --git a/frappe/public/js/frappe/form/controls/autocomplete.js b/frappe/public/js/frappe/form/controls/autocomplete.js
index 1bc0ffeb8a..ce3f75178a 100644
--- a/frappe/public/js/frappe/form/controls/autocomplete.js
+++ b/frappe/public/js/frappe/form/controls/autocomplete.js
@@ -15,6 +15,17 @@ frappe.ui.form.ControlAutocomplete = class ControlAutoComplete extends frappe.ui
 		}
 	}
 
+	format_for_input(value) {
+		if (value == null) {
+			return "";
+		} else if (this._data && this._data.length) {
+			const item = this._data.find(i => i.value == value);
+			return item ? item.label : value;
+		} else {
+			return value;
+		}
+	}
+
 	get_awesomplete_settings() {
 		var me = this;
 		return {
diff --git a/frappe/public/js/frappe/form/formatters.js b/frappe/public/js/frappe/form/formatters.js
index fd3fcb1bc7..291a467d97 100644
--- a/frappe/public/js/frappe/form/formatters.js
+++ b/frappe/public/js/frappe/form/formatters.js
@@ -21,6 +21,9 @@ frappe.form.formatters = {
 		}
 		return value==null ? "" : value;
 	},
+	Autocomplete: function(value) {
+		return __(frappe.form.formatters["Data"](value));
+	},
 	Select: function(value) {
 		return __(frappe.form.formatters["Data"](value));
 	},