vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

refactor: pass only wrapper to base notification

Browse source
This commit is contained in:
Shivam Mishra 2020-07-08 13:33:10 +05:30
parent eec6bf2c4f
commit 1275af43cd
1 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
frappe/public/js/frappe/ui/notifications/notifications.js
View file

@ -23,7 +23,6 @@ frappe.ui.Notifications = class Notifications {
);
this.user = frappe.session.user;
this.max_length = 20;
this.setup_headers();
let me = this;
@ -97,10 +96,7 @@ frappe.ui.Notifications = class Notifications {
}
make_tab_view(item) {
let tabView = new item.view({
wrapper: this.body,
max_length: this.max_length
});
let tabView = new item.view(this.body);
this.tabs[item.id] = tabView;
this.current_tab = tabView;
tabView.show();
@ -235,9 +231,10 @@ frappe.ui.notifications = {
};
class BaseNotificaitonsView {
constructor(opts) {
constructor(wrapper) {
// wrapper, max_length
Object.assign(this, opts)
this.wrapper = wrapper;
this.max_length = 20;
this.container = $(`<div></div>`).appendTo(this.wrapper);
this.make();
}