From 127ff39d2a3959f0df988d4cf21762f481b294ef Mon Sep 17 00:00:00 2001 From: Aditya Hase Date: Tue, 19 Feb 2019 18:42:13 +0530 Subject: [PATCH] test(recorder): fallback to mariadb if sql dialect is not defined --- frappe/tests/test_recorder.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/frappe/tests/test_recorder.py b/frappe/tests/test_recorder.py index aaaac2854d..3c5e93e194 100644 --- a/frappe/tests/test_recorder.py +++ b/frappe/tests/test_recorder.py @@ -85,8 +85,10 @@ class TestRecorder(unittest.TestCase): {'mariadb': 'SELECT COUNT(*) FROM tabDocType', 'postgres': 'SELECT COUNT(*) FROM "tabDocType"'}, {'mariadb': 'COMMIT', 'postgres': 'COMMIT'}, ] + + sql_dialect = frappe.conf.db_type or 'mariadb' for query in queries: - frappe.db.sql(query[frappe.conf.db_type]) + frappe.db.sql(query[sql_dialect]) frappe.recorder.dump() @@ -96,7 +98,7 @@ class TestRecorder(unittest.TestCase): self.assertEqual(len(request['calls']), len(queries)) for query, call in zip(queries, request['calls']): - self.assertEqual(call['query'], sqlparse.format(query[frappe.conf.db_type].strip(), keyword_case='upper', reindent=True)) + self.assertEqual(call['query'], sqlparse.format(query[sql_dialect].strip(), keyword_case='upper', reindent=True)) def test_duplicate_queries(self): queries = [