vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

ci: balance test distribution manually

Browse source 
Currently one test runner takes significantly longer than another. This
is entirely due to test_commands.py which needs to create new site and
do backup/restore tests etc. All of which are far far slower than other
tests.
This commit is contained in:
Ankush Menat 2025-01-04 10:30:30 +05:30
parent ded8cdfcb7
commit 13304cd36d
3 changed files with 14 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

0
frappe/tests/test_commands.py → frappe/commands/test_commands.py
View file

3
frappe/commands/testing.py
View file

@ -360,8 +360,7 @@ def run_parallel_tests(
║ App: {app:<26} ║
║ Site: {site:<26} ║
║ Build Number: {build_number:<26} ║
║ Total Builds: {total_builds:<26} ║
║ Tests in Build: ~{runner.total_tests:<25} ║"""
║ Total Builds: {total_builds:<26} ║"""
if cc.with_coverage:
banner += """
║ Coverage Rep.: {cc.outfile:<26} ║"""

19
frappe/parallel_test_runner.py
View file

@ -21,6 +21,12 @@ click_ctx = click.get_current_context(True)
if click_ctx:
click_ctx.color = True
TEST_WEIGHT_OVERRIDES = {
# XXX: command tests are significantly overweight, need a better heuristic than test count
# Possible better solution: stats from previous test runs.
"test_commands.py": 20,
}
class ParallelTestRunner:
def __init__(self, app, site, build_number=1, total_builds=1, dry_run=False):
@ -30,7 +36,7 @@ class ParallelTestRunner:
self.total_builds = frappe.utils.cint(total_builds)
self.dry_run = dry_run
self.test_file_list = []
self.total_tests = 0
self.total_test_weight = 0
self.test_result = None
self.setup_test_file_list()
@ -70,8 +76,7 @@ class ParallelTestRunner:
def setup_test_file_list(self):
self.test_file_list = self.get_test_file_list()
self.total_tests = sum(self.get_test_count(test) for test in self.test_file_list)
click.echo(f"Estimated total tests for build {self.build_number}: {self.total_tests}")
self.total_test_weight = sum(self.get_test_weight(test) for test in self.test_file_list)
def run_tests(self):
self.test_result = TestResult(stream=sys.stderr, descriptions=True, verbosity=2)
@ -136,18 +141,20 @@ class ParallelTestRunner:
# Load balance based on total # of tests ~ each runner should get roughly same # of tests.
test_list = get_all_tests(self.app)
test_counts = [self.get_test_count(test) for test in test_list]
test_counts = [self.get_test_weight(test) for test in test_list]
test_chunks = split_by_weight(test_list, test_counts, chunk_count=self.total_builds)
return test_chunks[self.build_number - 1]
@staticmethod
def get_test_count(test):
def get_test_weight(test):
"""Get approximate count of tests inside a file"""
file_name = "/".join(test)
test_weight = TEST_WEIGHT_OVERRIDES.get(test[-1]) or 1
with open(file_name) as f:
test_count = f.read().count("def test_")
test_count = f.read().count("def test_") * test_weight
return test_count