diff --git a/frappe/public/js/workflow_builder/store.js b/frappe/public/js/workflow_builder/store.js index e654014415..53e16304f1 100644 --- a/frappe/public/js/workflow_builder/store.js +++ b/frappe/public/js/workflow_builder/store.js @@ -152,15 +152,15 @@ export const useStore = defineStore("workflow-builder-store", () => { function reset_non_submittable_states() { if (is_submittable.value) return; - let affected_states = []; + let has_affected_states = false; workflow.value.elements.forEach((el) => { if (el.type === "state" && el.data.doc_status && el.data.doc_status !== "Draft") { - affected_states.push(el.data.state); + has_affected_states = true; el.data.doc_status = "Draft"; } }); - if (affected_states.length) { + if (has_affected_states) { frappe.msgprint({ title: __("Doc Status Reset"), message: __( diff --git a/frappe/workflow/doctype/workflow/workflow.js b/frappe/workflow/doctype/workflow/workflow.js index 05f99ce9d9..440e636332 100644 --- a/frappe/workflow/doctype/workflow/workflow.js +++ b/frappe/workflow/doctype/workflow/workflow.js @@ -128,14 +128,14 @@ frappe.ui.form.on("Workflow", { ); if (!is_submittable) { - let affected_states = []; + let has_affected_states = false; frm.doc.states.forEach((row) => { if (parseInt(row.doc_status || 0) !== 0) { - affected_states.push(row.state); + has_affected_states = true; row.doc_status = "0"; } }); - if (affected_states.length) { + if (has_affected_states) { frm.refresh_field("states"); frappe.msgprint({ title: __("Doc Status Reset"),