From 13e7f453fcc70e90fd5dfff4d81bc3ddddc2b1d5 Mon Sep 17 00:00:00 2001 From: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com> Date: Mon, 5 Apr 2021 11:45:14 +0530 Subject: [PATCH] fix: Handle exception while building version comment (#12801) --- .../version_timeline_content_builder.js | 26 +++++++++++-------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/frappe/public/js/frappe/form/footer/version_timeline_content_builder.js b/frappe/public/js/frappe/form/footer/version_timeline_content_builder.js index a563286413..cbfd620e4c 100644 --- a/frappe/public/js/frappe/form/footer/version_timeline_content_builder.js +++ b/frappe/public/js/frappe/form/footer/version_timeline_content_builder.js @@ -151,19 +151,23 @@ function get_version_comment(version_doc, text) { let version_comment = ""; let unlinked_content = ""; - Array.from($(text)).forEach(element => { - if ($(element).is('a')) { - version_comment += unlinked_content ? frappe.utils.get_form_link('Version', version_doc.name, true, unlinked_content) : ""; - unlinked_content = ""; - version_comment += element.outerHTML; - } else { - unlinked_content += element.outerHTML || element.textContent; + try { + Array.from($(text)).forEach(element => { + if ($(element).is('a')) { + version_comment += unlinked_content ? frappe.utils.get_form_link('Version', version_doc.name, true, unlinked_content) : ""; + unlinked_content = ""; + version_comment += element.outerHTML; + } else { + unlinked_content += element.outerHTML || element.textContent; + } + }); + if (unlinked_content) { + version_comment += frappe.utils.get_form_link('Version', version_doc.name, true, unlinked_content); } - }); - if (unlinked_content) { - version_comment += frappe.utils.get_form_link('Version', version_doc.name, true, unlinked_content); + return version_comment; + } catch (e) { + // pass } - return version_comment; } return frappe.utils.get_form_link('Version', version_doc.name, true, text); }