From 146d50e5d479693d3e9a65abc8fbd4cf0321a224 Mon Sep 17 00:00:00 2001 From: Sagar Vora Date: Wed, 5 Mar 2025 08:27:21 +0530 Subject: [PATCH] chore: fix typo in new `DocStatus` constant --- frappe/desk/form/save.py | 4 ++-- frappe/model/docstatus.py | 6 +++--- frappe/model/document.py | 4 ++-- frappe/tests/test_docstatus.py | 8 ++++---- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/frappe/desk/form/save.py b/frappe/desk/form/save.py index 89315eef4e..c3da6b1870 100644 --- a/frappe/desk/form/save.py +++ b/frappe/desk/form/save.py @@ -29,8 +29,8 @@ def savedocs(doc, action): # action doc.docstatus = { "Save": DocStatus.DRAFT, - "Submit": DocStatus.SUMBITTED, - "Update": DocStatus.SUMBITTED, + "Submit": DocStatus.SUBMITTED, + "Update": DocStatus.SUBMITTED, "Cancel": DocStatus.CANCELLED, }[action] diff --git a/frappe/model/docstatus.py b/frappe/model/docstatus.py index 8b4f38ec18..2e27dc8195 100644 --- a/frappe/model/docstatus.py +++ b/frappe/model/docstatus.py @@ -7,7 +7,7 @@ class DocStatus(int): return self == DocStatus.DRAFT def is_submitted(self): - return self == DocStatus.SUMBITTED + return self == DocStatus.SUBMITTED def is_cancelled(self): return self == DocStatus.CANCELLED @@ -20,7 +20,7 @@ class DocStatus(int): @staticmethod def submitted(): - return DocStatus.SUMBITTED + return DocStatus.SUBMITTED @staticmethod def cancelled(): @@ -28,5 +28,5 @@ class DocStatus(int): DocStatus.DRAFT = DocStatus(0) -DocStatus.SUMBITTED = DocStatus(1) +DocStatus.SUBMITTED = DocStatus(1) DocStatus.CANCELLED = DocStatus(2) diff --git a/frappe/model/document.py b/frappe/model/document.py index 55b472c2a0..f0a3a5dc36 100644 --- a/frappe/model/document.py +++ b/frappe/model/document.py @@ -1008,7 +1008,7 @@ class Document(BaseDocument, DocRef): else: raise frappe.ValidationError(_("Invalid docstatus"), self.docstatus) - elif to_docstatus == DocStatus.SUMBITTED: + elif to_docstatus == DocStatus.SUBMITTED: if self.docstatus.is_submitted(): self._action = "update_after_submit" self.check_permission("submit") @@ -1188,7 +1188,7 @@ class Document(BaseDocument, DocRef): def _submit(self): """Submit the document. Sets `docstatus` = 1, then saves.""" - self.docstatus = DocStatus.SUMBITTED + self.docstatus = DocStatus.SUBMITTED return self.save() def _cancel(self): diff --git a/frappe/tests/test_docstatus.py b/frappe/tests/test_docstatus.py index 674bbe470d..1b5e9ba427 100644 --- a/frappe/tests/test_docstatus.py +++ b/frappe/tests/test_docstatus.py @@ -11,11 +11,11 @@ class TestDocStatus(IntegrationTestCase): self.assertFalse(DocStatus.DRAFT.is_submitted()) def test_submitted(self): - self.assertEqual(DocStatus(1), DocStatus.SUMBITTED) + self.assertEqual(DocStatus(1), DocStatus.SUBMITTED) - self.assertFalse(DocStatus.SUMBITTED.is_draft()) - self.assertTrue(DocStatus.SUMBITTED.is_submitted()) - self.assertFalse(DocStatus.SUMBITTED.is_cancelled()) + self.assertFalse(DocStatus.SUBMITTED.is_draft()) + self.assertTrue(DocStatus.SUBMITTED.is_submitted()) + self.assertFalse(DocStatus.SUBMITTED.is_cancelled()) def test_cancelled(self): self.assertEqual(DocStatus(2), DocStatus.CANCELLED)