From 14798146c7aadf993b514782b7c0c129a7bb1ebb Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Wed, 12 Jul 2023 22:22:34 +0530 Subject: [PATCH] fix: Conditionally show extra info for perm error (#21660) --- frappe/permissions.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/frappe/permissions.py b/frappe/permissions.py index e8ca0ecb3c..ae26b56b2e 100644 --- a/frappe/permissions.py +++ b/frappe/permissions.py @@ -93,10 +93,10 @@ def has_permission( doc = frappe.get_doc(meta.name, doc) perm = get_doc_permissions(doc, user=user, ptype=ptype).get(ptype) if not perm: - push_perm_check_log( - _("User {0} does not have access to this document").format(frappe.bold(user)) - + f": {_(doc.doctype)} - {doc.name}" - ) + msg = _("User {0} does not have access to this document").format(frappe.bold(user)) + if frappe.has_permission(doc.doctype): + msg += f": {_(doc.doctype)} - {doc.name}" + push_perm_check_log(msg) else: if ptype == "submit" and not cint(meta.is_submittable): push_perm_check_log(_("Document Type is not submittable"))