vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(control): Check if same value is set to avoid unnecessary change trigger

Browse source
This commit is contained in:
Suraj Shetty 2021-04-22 14:21:05 +05:30
parent 1a30e11b5f
commit 162f191b77
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.eslintrc
View file

@ -143,6 +143,7 @@
"Cypress": true, "Cypress": true,
"cy": true, "cy": true,
"it": true, "it": true,
"describe": true,
"expect": true, "expect": true,
"context": true, "context": true,
"before": true, "before": true,

3
frappe/public/js/frappe/form/controls/base_control.js
View file

@ -159,9 +159,10 @@ frappe.ui.form.Control = Class.extend({
}, },
validate_and_set_in_model: function(value, e) { validate_and_set_in_model: function(value, e) {
var me = this; var me = this;
if(this.inside_change_event) { if (this.inside_change_event || this.get_model_value() === value) {
return Promise.resolve(); return Promise.resolve();
} }
this.inside_change_event = true; this.inside_change_event = true;
var set = function(value) { var set = function(value) {
me.inside_change_event = false; me.inside_change_event = false;