vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: Avoid erasing recorder during clear_cache

Browse source 
This reverts commit eadfe86fd834f43925956fa6d759127aaf363441.
This commit is contained in:
Ankush Menat 2024-05-13 17:38:11 +05:30
parent aba8d4e5b5
commit 16c8a30861
2 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
frappe/hooks.py
View file

@ -549,7 +549,7 @@ default_log_clearing_doctypes = {
# These keys will not be erased when doing frappe.clear_cache()
persistent_cache_keys = [
"update-user-set",
"update-info",
"changelog-*", # version update notifications
"insert_queue_for_*", # Deferred Insert
"recorder-*", # Recorder
]

14
frappe/utils/change_log.py
View file

@ -212,7 +212,7 @@ def check_for_update():
def has_app_update_notifications() -> bool:
return bool(frappe.cache.sismember("update-user-set", frappe.session.user))
return bool(frappe.cache.sismember("changelog-update-user-set", frappe.session.user))
def parse_latest_non_beta_release(response: list, current_version: Version) -> list | None:
@ -324,11 +324,11 @@ def get_source_url(app: str) -> str | None:
def add_message_to_redis(update_json):
# "update-message" will store the update message string
# "update-user-set" will be a set of users
frappe.cache.set_value("update-info", json.dumps(update_json))
# "changelog-update-user-set" will be a set of users
frappe.cache.set_value("changelog-update-info", json.dumps(update_json))
user_list = [x.name for x in frappe.get_all("User", filters={"enabled": True})]
system_managers = [user for user in user_list if "System Manager" in frappe.get_roles(user)]
frappe.cache.sadd("update-user-set", *system_managers)
frappe.cache.sadd("changelog-update-user-set", *system_managers)
@frappe.whitelist()
@ -337,7 +337,7 @@ def show_update_popup():
return
user = frappe.session.user
update_info = frappe.cache.get_value("update-info")
update_info = frappe.cache.get_value("changelog-update-info")
if not update_info:
return
@ -345,7 +345,7 @@ def show_update_popup():
# Check if user is int the set of users to send update message to
update_message = ""
if frappe.cache.sismember("update-user-set", user):
if frappe.cache.sismember("changelog-update-user-set", user):
for update_type in updates:
release_links = ""
for app in updates[update_type]:
@ -390,7 +390,7 @@ def show_update_popup():
indicator="green",
primary_action=primary_action,
)
frappe.cache.srem("update-user-set", user)
frappe.cache.srem("changelog-update-user-set", user)
def get_pyproject(app: str) -> dict | None: