From 16fdff8231ef03868930c50b0dbcc3f142fe55a4 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Thu, 4 Aug 2022 15:24:34 +0530 Subject: [PATCH] chore: remove pointless template strings --- frappe/public/js/frappe/form/quick_entry.js | 2 +- frappe/public/js/frappe/list/list_view_select.js | 4 ++-- .../public/js/frappe/views/workspace/blocks/header.js | 2 +- .../js/frappe/views/workspace/blocks/paragraph.js | 2 +- .../public/js/frappe/views/workspace/blocks/spacer.js | 2 +- frappe/public/js/frappe/views/workspace/workspace.js | 6 +++--- frappe/public/js/frappe/widgets/base_widget.js | 10 +++++----- 7 files changed, 14 insertions(+), 14 deletions(-) diff --git a/frappe/public/js/frappe/form/quick_entry.js b/frappe/public/js/frappe/form/quick_entry.js index acd435ff4d..aea8d07f57 100644 --- a/frappe/public/js/frappe/form/quick_entry.js +++ b/frappe/public/js/frappe/form/quick_entry.js @@ -281,7 +281,7 @@ frappe.ui.form.QuickEntryForm = class QuickEntryForm { render_edit_in_full_page_link() { var me = this; - this.dialog.add_custom_action(`${__("Edit Full Form")}`, () => me.open_doc(true)); + this.dialog.add_custom_action(__("Edit Full Form"), () => me.open_doc(true)); } set_defaults() { diff --git a/frappe/public/js/frappe/list/list_view_select.js b/frappe/public/js/frappe/list/list_view_select.js index 15aa824a51..4af1268f68 100644 --- a/frappe/public/js/frappe/list/list_view_select.js +++ b/frappe/public/js/frappe/list/list_view_select.js @@ -142,10 +142,10 @@ frappe.views.ListViewSelect = class ListViewSelect { setup_dropdown_in_sidebar(view, items, default_action) { if (!this.sidebar) return; const views_wrapper = this.sidebar.sidebar.find(".views-section"); - views_wrapper.find(".sidebar-label").html(`${__(view)}`); + views_wrapper.find(".sidebar-label").html(__(view)); const $dropdown = views_wrapper.find(".views-dropdown"); - let placeholder = `${__("Select {0}", [__(view)])}`; + let placeholder = __("Select {0}", [__(view)]); let html = ``; if (!items || !items.length) { diff --git a/frappe/public/js/frappe/views/workspace/blocks/header.js b/frappe/public/js/frappe/views/workspace/blocks/header.js index 6e8dd680c2..b5b42796d4 100644 --- a/frappe/public/js/frappe/views/workspace/blocks/header.js +++ b/frappe/public/js/frappe/views/workspace/blocks/header.js @@ -43,7 +43,7 @@ export default class Header extends Block { frappe.utils.icon("drag", "xs"), null, "drag-handle", - `${__("Drag")}`, + __("Drag"), null, $widget_control ); diff --git a/frappe/public/js/frappe/views/workspace/blocks/paragraph.js b/frappe/public/js/frappe/views/workspace/blocks/paragraph.js index c742d886ee..3c49f5460b 100644 --- a/frappe/public/js/frappe/views/workspace/blocks/paragraph.js +++ b/frappe/public/js/frappe/views/workspace/blocks/paragraph.js @@ -133,7 +133,7 @@ export default class Paragraph extends Block { frappe.utils.icon("drag", "xs"), null, "drag-handle", - `${__("Drag")}`, + __("Drag"), null, $para_control ); diff --git a/frappe/public/js/frappe/views/workspace/blocks/spacer.js b/frappe/public/js/frappe/views/workspace/blocks/spacer.js index dc99a8bdfb..aa5c3684d2 100644 --- a/frappe/public/js/frappe/views/workspace/blocks/spacer.js +++ b/frappe/public/js/frappe/views/workspace/blocks/spacer.js @@ -41,7 +41,7 @@ export default class Spacer extends Block { frappe.utils.icon("drag", "xs"), null, "drag-handle", - `${__("Drag")}`, + __("Drag"), null, $widget_control ); diff --git a/frappe/public/js/frappe/views/workspace/workspace.js b/frappe/public/js/frappe/views/workspace/workspace.js index 2c5932e170..88ff21caa7 100644 --- a/frappe/public/js/frappe/views/workspace/workspace.js +++ b/frappe/public/js/frappe/views/workspace/workspace.js @@ -222,7 +222,7 @@ frappe.views.Workspace = class Workspace { } let page = this.get_page_to_show(); - this.page.set_title(`${__(page.name)}`); + this.page.set_title(__(page.name)); this.update_selected_sidebar(this.current_page, false); //remove selected from old page this.update_selected_sidebar(page, true); //add selected on new page @@ -476,7 +476,7 @@ frappe.views.Workspace = class Workspace { frappe.utils.icon("duplicate", "sm"), () => this.duplicate_page(item), "duplicate-page", - `${__("Duplicate Workspace")}`, + __("Duplicate Workspace"), null, sidebar_control ); @@ -485,7 +485,7 @@ frappe.views.Workspace = class Workspace { frappe.utils.icon("drag", "xs"), null, "drag-handle", - `${__("Drag")}`, + __("Drag"), null, sidebar_control ); diff --git a/frappe/public/js/frappe/widgets/base_widget.js b/frappe/public/js/frappe/widgets/base_widget.js index c01494ed10..714a447b94 100644 --- a/frappe/public/js/frappe/widgets/base_widget.js +++ b/frappe/public/js/frappe/widgets/base_widget.js @@ -30,7 +30,7 @@ export default class Widget { frappe.utils.icon("drag", "xs"), null, "drag-handle", - `${__("Drag")}`, + __("Drag"), null, this.action_area ); @@ -43,7 +43,7 @@ export default class Widget { this.footer.css("opacity", 0.5); } const classname = this.hidden ? "fa fa-eye" : "fa fa-eye-slash"; - const title = this.hidden ? `${__("Show")}` : `${__("Hide")}`; + const title = this.hidden ? __("Show") : __("Hide"); frappe.utils.add_custom_button( ``, () => this.hide_or_show(), @@ -61,7 +61,7 @@ export default class Widget { frappe.utils.icon("edit", "xs"), () => this.edit(), "edit-button", - `${__("Edit")}`, + __("Edit"), null, this.action_area ); @@ -158,7 +158,7 @@ export default class Widget { this.refresh(); } - const title = this.width == "Full" ? `${__("Collapse")}` : `${__("Expand")}`; + const title = this.width == "Full" ? __("Collapse") : __("Expand"); this.resize_button.attr("title", title); } @@ -177,7 +177,7 @@ export default class Widget { this.show_or_hide_button.empty(); const classname = this.hidden ? "fa fa-eye" : "fa fa-eye-slash"; - const title = this.hidden ? `${__("Show")}` : `${__("Hide")}`; + const title = this.hidden ? __("Show") : __("Hide"); $(``).appendTo( this.show_or_hide_button