From 65b55f6a9074b493f75801788d4cfcd084afc673 Mon Sep 17 00:00:00 2001 From: Suraj Shetty Date: Fri, 2 Apr 2021 16:24:29 +0530 Subject: [PATCH] fix: Check if doctype is virtual doctype before getting value --- frappe/database/database.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/frappe/database/database.py b/frappe/database/database.py index 7fe76c799b..f731ff9471 100644 --- a/frappe/database/database.py +++ b/frappe/database/database.py @@ -455,9 +455,9 @@ class Database(object): elif (not ignore) and frappe.db.is_table_missing(e): # table not found, look in singles out = self.get_values_from_single(fields, filters, doctype, as_dict, debug, update) - if not out: + if not out and frappe.get_meta(doctype).get('is_virtual'): # check for virtual doctype - out = self.get_values_from_virtual_doctype(fields, filters, doctype, as_dict, debug, update) + out = self.get_value_from_virtual_doctype(fields, filters, doctype, as_dict, debug, update) else: raise @@ -511,9 +511,9 @@ class Database(object): else: return r and [[i[1] for i in r]] or [] - def get_values_from_virtual_doctype(self, fields, filters, doctype, as_dict=False, debug=False, update=None): - """Reture single values from virtual doctype.""" - return frappe.get_doc(doctype).get_value(fields, filters, as_dict=False, debug=False, update=None) + def get_value_from_virtual_doctype(self, fields, filters, doctype, as_dict=False, debug=False, update=None): + """Return a single value from virtual doctype.""" + return frappe.get_doc(doctype).get_value(fields, filters, as_dict=as_dict, debug=debug, update=update) def get_singles_dict(self, doctype, debug = False): """Get Single DocType as dict.