vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(printview): ensure document title is a string

Browse source 
Nothing is stopping people from setting non-string types as their title

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
This commit is contained in:
Akhil Narang 2024-09-12 13:34:23 +05:30
parent cca88f3a47
commit 182dc7213d
No known key found for this signature in database
GPG key ID: 9DCC61E211BF645F
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
frappe/www/printview.py
View file

@ -8,7 +8,7 @@ import re
from typing import TYPE_CHECKING, Optional, TypedDict
import frappe
from frappe import _, get_module_path
from frappe import _, cstr, get_module_path
from frappe.core.doctype.access_log.access_log import make_access_log
from frappe.core.doctype.document_share_key.document_share_key import is_expired
from frappe.utils import cint, escape_html, strip_html
@ -68,7 +68,6 @@ def get_context(context) -> PrintContext:
doctype=frappe.form_dict.doctype, document=frappe.form_dict.name, file_type="PDF", method="Print"
)
print_style = None
body = get_rendered_template(
doc,
print_format=print_format,
@ -84,7 +83,7 @@ def get_context(context) -> PrintContext:
"body": body,
"print_style": print_style,
"comment": frappe.session.user,
"title": frappe.utils.strip_html(doc.get_title() or doc.name),
"title": frappe.utils.strip_html(cstr(doc.get_title() or doc.name)),
"lang": frappe.local.lang,
"layout_direction": "rtl" if is_rtl() else "ltr",
"doctype": frappe.form_dict.doctype,