From 188ea01c556d880d1e8d3b1fb4e2bd4d7d4ec49c Mon Sep 17 00:00:00 2001
From: Shivam Mishra <scmmishra@users.noreply.github.com>
Date: Mon, 29 Jul 2019 15:15:22 +0530
Subject: [PATCH] fix: translations for fields in webform list (#8026)

* refactor: translated table fields

* Update web_form_list.js

* chore: added Sr to translated items
---
 frappe/public/js/frappe/web_form/web_form_list.js | 11 ++++-------
 frappe/website/doctype/web_form/web_form.py       |  2 ++
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/frappe/public/js/frappe/web_form/web_form_list.js b/frappe/public/js/frappe/web_form/web_form_list.js
index c92b62f013..7b14844c6f 100644
--- a/frappe/public/js/frappe/web_form/web_form_list.js
+++ b/frappe/public/js/frappe/web_form/web_form_list.js
@@ -151,12 +151,9 @@ export default class WebFormList {
 		th.appendChild(checkbox);
 		row.appendChild(th);
 
-		add_heading(row, "Sr.");
+		add_heading(row, __("Sr"));
 		this.columns.forEach(col => {
-			let th = document.createElement("th");
-			let text = document.createTextNode(__(col.label));
-			th.appendChild(text);
-			row.appendChild(th);
+			add_heading(row, __(col.label));
 		});
 
 		function add_heading(row, label) {
@@ -301,7 +298,7 @@ frappe.ui.WebFormListRow = class WebFormListRow {
 			let cell = this.row.insertCell();
 			let formatter = frappe.form.get_formatter(field.fieldtype);
 			cell.innerHTML = this.doc[field.fieldname] &&
-				formatter(this.doc[field.fieldname], field, {only_value: 1}, this.doc) || "";
+				__(formatter(this.doc[field.fieldname], field, {only_value: 1}, this.doc)) || "";
 		});
 
 		this.row.onclick = () => this.events.onEdit();
@@ -316,4 +313,4 @@ frappe.ui.WebFormListRow = class WebFormListRow {
 	is_selected() {
 		return this.checkbox.checked;
 	}
-};
\ No newline at end of file
+};
diff --git a/frappe/website/doctype/web_form/web_form.py b/frappe/website/doctype/web_form/web_form.py
index 0ba80a4591..94159e13a4 100644
--- a/frappe/website/doctype/web_form/web_form.py
+++ b/frappe/website/doctype/web_form/web_form.py
@@ -177,6 +177,8 @@ def get_context(context):
 
 	def load_translations(self, context):
 		translated_messages = frappe.translate.get_dict('doctype', self.doc_type)
+		# Sr is not added by default, had to be added manually
+		translated_messages['Sr'] = _('Sr')
 		context.translated_messages = frappe.as_json(translated_messages)
 
 	def load_document(self, context):