From 1a7da4f025b0e7879017c49206ccffdc2293e0c2 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Thu, 3 Jul 2025 18:19:23 +0530 Subject: [PATCH] fix: keep setup_complete in sync with rest (#33215) For backward compatbility of whatever reads System Settings. --- .../doctype/installed_applications/installed_applications.py | 2 ++ frappe/desk/page/setup_wizard/setup_wizard.py | 2 ++ 2 files changed, 4 insertions(+) diff --git a/frappe/core/doctype/installed_applications/installed_applications.py b/frappe/core/doctype/installed_applications/installed_applications.py index 7e27e15d6f..b589a009ed 100644 --- a/frappe/core/doctype/installed_applications/installed_applications.py +++ b/frappe/core/doctype/installed_applications/installed_applications.py @@ -54,6 +54,8 @@ class InstalledApplications(Document): ) self.save() + frappe.clear_cache(doctype="System Settings") + frappe.db.set_single_value("System Settings", "setup_complete", frappe.is_setup_complete()) def get_app_wise_setup_details(self): """Get app wise setup details from the Installed Application doctype""" diff --git a/frappe/desk/page/setup_wizard/setup_wizard.py b/frappe/desk/page/setup_wizard/setup_wizard.py index 3fd4b8b307..401e6887d2 100755 --- a/frappe/desk/page/setup_wizard/setup_wizard.py +++ b/frappe/desk/page/setup_wizard/setup_wizard.py @@ -369,7 +369,9 @@ def _get_default_roles() -> set[str]: def disable_future_access(): frappe.db.set_default("desktop:home_page", "workspace") # Enable onboarding after install + frappe.clear_cache(doctype="System Settings") frappe.db.set_single_value("System Settings", "enable_onboarding", 1) + frappe.db.set_single_value("System Settings", "setup_complete", frappe.is_setup_complete()) @frappe.whitelist()