From b593285b568f9206cca1694dede5198f2bf2d248 Mon Sep 17 00:00:00 2001 From: Shrihari Mahabal Date: Wed, 22 Apr 2026 14:47:11 +0530 Subject: [PATCH] fix: escape icon and color fields --- frappe/public/js/frappe/form/formatters.js | 24 +++++++++++----------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/frappe/public/js/frappe/form/formatters.js b/frappe/public/js/frappe/form/formatters.js index f9e5fc3755..1761411edb 100644 --- a/frappe/public/js/frappe/form/formatters.js +++ b/frappe/public/js/frappe/form/formatters.js @@ -394,20 +394,20 @@ frappe.form.formatters = { return formatted_values.join(", "); }, Color: (value) => { - return value - ? `
-
- ${value} -
` - : ""; + if (!value) return ""; + let escaped_value = frappe.utils.escape_html(value); + return `
+
+ ${escaped_value} +
`; }, Icon: (value) => { - return value - ? `
-
${frappe.utils.icon(value, "md")}
- ${value} -
` - : ""; + if (!value) return ""; + let escaped_value = frappe.utils.escape_html(value); + return `
+
${frappe.utils.icon(escaped_value, "md")}
+ ${escaped_value} +
`; }, Attach: format_attachment_url, AttachImage: format_attachment_url,