From 1bfe585b71153e6d9acc69f8e45045899ef8bb71 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Mon, 24 Jul 2023 14:22:07 +0530 Subject: [PATCH] fix!: Drop unused link_doctype, link_name (#21788) --- frappe/core/doctype/comment/comment.json | 16 +--------------- frappe/desk/like.py | 18 +----------------- frappe/model/document.py | 4 ---- 3 files changed, 2 insertions(+), 36 deletions(-) diff --git a/frappe/core/doctype/comment/comment.json b/frappe/core/doctype/comment/comment.json index 9f27e7e7be..529c1d234c 100644 --- a/frappe/core/doctype/comment/comment.json +++ b/frappe/core/doctype/comment/comment.json @@ -14,8 +14,6 @@ "column_break_5", "reference_doctype", "reference_name", - "link_doctype", - "link_name", "reference_owner", "section_break_10", "content", @@ -76,18 +74,6 @@ "label": "Reference Name", "options": "reference_doctype" }, - { - "fieldname": "link_doctype", - "fieldtype": "Link", - "label": "Link DocType", - "options": "DocType" - }, - { - "fieldname": "link_name", - "fieldtype": "Dynamic Link", - "label": "Link Name", - "options": "link_doctype" - }, { "fieldname": "reference_owner", "fieldtype": "Data", @@ -113,7 +99,7 @@ } ], "links": [], - "modified": "2022-07-12 17:35:31.774137", + "modified": "2023-07-24 13:52:55.651462", "modified_by": "Administrator", "module": "Core", "name": "Comment", diff --git a/frappe/desk/like.py b/frappe/desk/like.py index 60eea3c525..2be2362b2d 100644 --- a/frappe/desk/like.py +++ b/frappe/desk/like.py @@ -88,20 +88,4 @@ def remove_like(doctype, name): def add_comment(doctype, name): doc = frappe.get_doc(doctype, name) - - if doctype == "Communication" and doc.reference_doctype and doc.reference_name: - link = get_link_to_form( - doc.reference_doctype, - doc.reference_name, - f"{_(doc.reference_doctype)} {doc.reference_name}", - ) - - doc.add_comment( - "Like", - _("{0}: {1} in {2}").format(_(doc.communication_type), "" + doc.subject + "", link), - link_doctype=doc.reference_doctype, - link_name=doc.reference_name, - ) - - else: - doc.add_comment("Like", _("Liked")) + doc.add_comment("Like", _("Liked")) diff --git a/frappe/model/document.py b/frappe/model/document.py index d503bdc176..7130a727e0 100644 --- a/frappe/model/document.py +++ b/frappe/model/document.py @@ -1361,8 +1361,6 @@ class Document(BaseDocument): comment_type="Comment", text=None, comment_email=None, - link_doctype=None, - link_name=None, comment_by=None, ): """Add a comment to this document. @@ -1378,8 +1376,6 @@ class Document(BaseDocument): "reference_doctype": self.doctype, "reference_name": self.name, "content": text or comment_type, - "link_doctype": link_doctype, - "link_name": link_name, } ).insert(ignore_permissions=True) return out