From 27a5a920d40f13ab138c1ba31bcfca3dd8b9484e Mon Sep 17 00:00:00 2001 From: Mangesh-Khairnar Date: Wed, 15 Jan 2020 16:19:34 +0530 Subject: [PATCH 1/2] fix: change message content for errors without a title --- frappe/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/__init__.py b/frappe/__init__.py index 4ab86e6b5d..2fa3e7a66c 100644 --- a/frappe/__init__.py +++ b/frappe/__init__.py @@ -1546,7 +1546,7 @@ def log_error(message=None, title=None): # this hack tries to be smart about whats a title (single line ;-)) and fixes it if message: - if '\n' not in message: + if '\n' not in message and not title: title = message error = get_traceback() else: From a4569172e499085ed6f2e18ca3632c4415ae8846 Mon Sep 17 00:00:00 2001 From: Mangesh-Khairnar Date: Thu, 16 Jan 2020 15:22:17 +0530 Subject: [PATCH 2/2] fix: swap message with title containing newline character --- frappe/__init__.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/frappe/__init__.py b/frappe/__init__.py index 2fa3e7a66c..01187541d3 100644 --- a/frappe/__init__.py +++ b/frappe/__init__.py @@ -1537,7 +1537,7 @@ def logger(module=None, with_more_info=True): from frappe.utils.logger import get_logger return get_logger(module or 'default', with_more_info=with_more_info) -def log_error(message=None, title=None): +def log_error(message=None, title=_("Error")): '''Log error to Error Log''' # AI ALERT: @@ -1546,9 +1546,8 @@ def log_error(message=None, title=None): # this hack tries to be smart about whats a title (single line ;-)) and fixes it if message: - if '\n' not in message and not title: - title = message - error = get_traceback() + if '\n' in title: + error, title = title, message else: error = message else: