vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

feat: show error state in dashboard chart widget instead of throwing … (#37837)

Browse source
This commit is contained in:
Shllokkk 2026-03-11 12:29:11 +05:30 • committed by GitHub
parent 8e681bd568
commit 1d07cee93d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
frappe/public/js/frappe/widgets/chart_widget.js
View file

@ -60,6 +60,11 @@ export default class ChartWidget extends Widget {
);
this.empty.hide().appendTo(this.body);
this.error_state = $(
`<div class="chart-loading-state text-danger" style="height: ${this.height}px;"></div>`
);
this.error_state.hide().appendTo(this.body);
this.chart_wrapper = $(`<div></div>`);
this.chart_wrapper.appendTo(this.body);
@ -552,7 +557,18 @@ export default class ChartWidget extends Widget {
heatmap_year: args && args.heatmap_year ? args.heatmap_year : null,
};
}
return frappe.xcall(method, args);
return frappe.xcall(method, args, undefined, {
silent: true,
error: (err) => {
const message = JSON.parse(JSON.parse(err._server_messages)[0])?.message;
this.chart_wrapper.hide();
this.loading.hide();
this.$summary && this.$summary.hide();
this.empty.hide();
this.error_state.text(message);
this.error_state.show();
},
});
}
async get_source_doctype() {
@ -588,9 +604,11 @@ export default class ChartWidget extends Widget {
this.loading.hide();
this.$summary && this.$summary.hide();
this.empty.show();
this.error_state.hide();
} else {
this.loading.hide();
this.empty.hide();
this.error_state.hide();
this.chart_wrapper.show();
this.chart_doc.document_type = await this.get_source_doctype();