Merge pull request #15975 from resilient-tech/fix-limit-without-filter

fix: limit without filter

frappe/model/base_document.py

@@ -153,6 +153,9 @@ class BaseDocument(object):
 				value = []
 				self.set(key, value)
 
+			if limit and isinstance(value, (list, tuple)) and len(value) > limit:
+				value = value[:limit]
+
 			return value
 		else:
 			return self.__dict__

frappe/tests/test_document.py

@@ -264,7 +264,10 @@ class TestDocument(unittest.TestCase):
 
 	def test_limit_for_get(self):
 		doc = frappe.get_doc("DocType", "DocType")
-		# assuming DocType has more that 3 Data fields
+		# assuming DocType has more than 3 Data fields
+		self.assertEquals(len(doc.get("fields", limit=3)), 3)
+
+		# limit with filters
 		self.assertEquals(len(doc.get("fields", filters={"fieldtype": "Data"}, limit=3)), 3)
 
 	def test_virtual_fields(self):